Andrew Morton
2015-Dec-08 21:22 UTC
[Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue
On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi <junxiao.bi at oracle.com> wrote:> commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, > SGID of sub dir was not inherited from its parents dir. It is because SGID > is set into "inode->i_mode" in ocfs2_get_init_inode(), but is overwritten > by "mode" which don't have SGID set later. > > Fixes: 8f1eb48758aa ("ocfs2: fix umask ignored issue") > Signed-off-by: Junxiao Bi <junxiao.bi at oracle.com> > Cc: <stable at vger.kernel.org>8f1eb48758aa is only in 4.4-rcX so I removed the cc:stable.
Junxiao Bi
2015-Dec-09 02:28 UTC
[Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue
Hi Andrew, On 12/09/2015 05:22 AM, Andrew Morton wrote:> On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi <junxiao.bi at oracle.com> wrote: > >> commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, >> SGID of sub dir was not inherited from its parents dir. It is because SGID >> is set into "inode->i_mode" in ocfs2_get_init_inode(), but is overwritten >> by "mode" which don't have SGID set later. >> >> Fixes: 8f1eb48758aa ("ocfs2: fix umask ignored issue") >> Signed-off-by: Junxiao Bi <junxiao.bi at oracle.com> >> Cc: <stable at vger.kernel.org> > > 8f1eb48758aa is only in 4.4-rcX so I removed the cc:stable.If 8f1eb48758aa is merged into stable, but this patch not, there will be a regression issue in stable branch? Thanks, Junxiao.>