Srinivas Eeda
2015-Aug-24 16:57 UTC
[Ocfs2-devel] [RFC] ocfs2: Idea to make ocfs2_search_chain high efficiency
Hi Norton, while the localalloc bmp is enabled the chances of a particular gd ending with zero free bits is very minimal. local alloc bmp will pick next gd once min number of free bits falls below localalloc bmp size. So next gd is picked while the current gd still has free space. Having said that, I understand the problem you are describing. Since we only move the gd with more free bits ahead of the previous unusable gd we end of rescanning unusable gds whenever the newly picked gd becomes unusable. This is inefficient and causes performance problem when fs gets fragmented I am not sure if we will be allowed to use the bg_reserved2 ... but if we are then we could use it to remember next gd we should look at. For example, if we assume there are 'N' GDs and we are currently seeing that GD10 has more free space ... so the order of GDs are GD10, GD1, GD2, ... GDN. Now if we end up using most of the space in GD10, according to current logic we re-read GD1, GD2.. GD9 and then read GD11 and pick that (assuming it has free space). But instead if we had GD10 remembers GD11 as the next one to look at ... then we can skip reading GD1..GD9. Thanks, --Srini On 08/24/2015 05:30 AM, Norton.Zhu wrote:> In ocfs2_search_chain, I found it has low efficiency while searching an available gd in some circumstances: > 1) The lun has a great many gd(it reads lots of unavailable gd(free bits is zero)); > 2) Not too many gd, but the available gd is scattered in the unavailable gd(fragmentation); > > So I have an idea to optimize the search method: > 1) Use the reserved member in the ocfs2_group_desc to make an available chain list(gds in the list are all available, free bits more than zero); > 2) At the beginning, the chain list is the same with origin chain list; > 3) While do allocation, it searches gd in the available chain list; > 4) After each allocation, if some gd's free bits is zero, Remove it from the available chain list; > 5) After each reclaim, if some gd's free bits change from zero to positive, Append it to the head of the available chain list; > > Once started with the basics outlined above, no unavailable gd will be read. > > Anyone has better ideas or advices? > > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > https://oss.oracle.com/mailman/listinfo/ocfs2-devel
Joel Becker
2015-Aug-25 01:47 UTC
[Ocfs2-devel] [RFC] ocfs2: Idea to make ocfs2_search_chain high efficiency
Srini has summed it up, mostly. We shouldn't be hitting these suboptimal chains of gds unless the localalloc is empty. Hopefully that's not terribly frequent, but it can happen. Your solution does increase the complexity of the commit. Pushing a newly-available gd back on to the available list is cheap, as you're already modifing the chain_rec and the gd. But deleting a full gd from the available list requires you to find the previous entry in the list and edit it as well. The lock ordering is hopefully not terrible. Joel On Mon, Aug 24, 2015 at 09:57:26AM -0700, Srinivas Eeda wrote:> Hi Norton, > > while the localalloc bmp is enabled the chances of a particular gd > ending with zero free bits is very minimal. local alloc bmp will pick > next gd once min number of free bits falls below localalloc bmp size. So > next gd is picked while the current gd still has free space. > > Having said that, I understand the problem you are describing. Since we > only move the gd with more free bits ahead of the previous unusable gd > we end of rescanning unusable gds whenever the newly picked gd becomes > unusable. This is inefficient and causes performance problem when fs > gets fragmented > > I am not sure if we will be allowed to use the bg_reserved2 ... but if > we are then we could use it to remember next gd we should look at. > > For example, if we assume there are 'N' GDs and we are currently seeing > that GD10 has more free space ... so the order of GDs are > > GD10, GD1, GD2, ... GDN. > > Now if we end up using most of the space in GD10, according to current > logic we re-read GD1, GD2.. GD9 and then read GD11 and pick that > (assuming it has free space). But instead if we had GD10 remembers GD11 > as the next one to look at ... then we can skip reading GD1..GD9. > > Thanks, > --Srini > > > On 08/24/2015 05:30 AM, Norton.Zhu wrote: > > In ocfs2_search_chain, I found it has low efficiency while searching an available gd in some circumstances: > > 1) The lun has a great many gd(it reads lots of unavailable gd(free bits is zero)); > > 2) Not too many gd, but the available gd is scattered in the unavailable gd(fragmentation); > > > > So I have an idea to optimize the search method: > > 1) Use the reserved member in the ocfs2_group_desc to make an available chain list(gds in the list are all available, free bits more than zero); > > 2) At the beginning, the chain list is the same with origin chain list; > > 3) While do allocation, it searches gd in the available chain list; > > 4) After each allocation, if some gd's free bits is zero, Remove it from the available chain list; > > 5) After each reclaim, if some gd's free bits change from zero to positive, Append it to the head of the available chain list; > > > > Once started with the basics outlined above, no unavailable gd will be read. > > > > Anyone has better ideas or advices? > > > > > > _______________________________________________ > > Ocfs2-devel mailing list > > Ocfs2-devel at oss.oracle.com > > https://oss.oracle.com/mailman/listinfo/ocfs2-devel > > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > https://oss.oracle.com/mailman/listinfo/ocfs2-devel--