Jan Kara
2015-Jan-16 12:47 UTC
[Ocfs2-devel] [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing
Call ->quota_sync method from Q_XQUOTASYNC for better userspace compatibility. Signed-off-by: Jan Kara <jack at suse.cz> --- fs/quota/quota.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/quota/quota.c b/fs/quota/quota.c index 2cc50b35a3b5..5ec04321aace 100644 --- a/fs/quota/quota.c +++ b/fs/quota/quota.c @@ -477,8 +477,9 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, case Q_XQUOTASYNC: if (sb->s_flags & MS_RDONLY) return -EROFS; - /* XFS quotas are fully coherent now, making this call a noop */ - return 0; + if (!sb->s_qcop->quota_sync) + return 0; + return sb->s_qcop->quota_sync(sb, type); default: return -EINVAL; } -- 2.1.2
Christoph Hellwig
2015-Jan-19 09:09 UTC
[Ocfs2-devel] [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing
On Fri, Jan 16, 2015 at 01:47:43PM +0100, Jan Kara wrote:> Call ->quota_sync method from Q_XQUOTASYNC for better userspace > compatibility.Q_XQUOTASYNC never did the equivalent to ->quota_sync, but rather was the equivalent to sys_syncfs which also happens to write out quotas. Unless you have a really strong reason for wiring it up, I'd rather keep it as-is.