Jan Kara
2014-Oct-21 15:02 UTC
[Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init()
Remove assignment which is never used.
Coverity-id: 1227009
Signed-off-by: Jan Kara <jack at suse.cz>
---
fs/ocfs2/super.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index 93c85bc745e1..e1be0f0ea411 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -1621,10 +1621,8 @@ static int __init ocfs2_init(void)
}
ocfs2_debugfs_root = debugfs_create_dir("ocfs2", NULL);
- if (!ocfs2_debugfs_root) {
- status = -EFAULT;
+ if (!ocfs2_debugfs_root)
mlog(ML_ERROR, "Unable to create ocfs2 debugfs root.\n");
- }
ocfs2_set_locking_protocol();
--
1.8.1.4
Joseph Qi
2014-Nov-06 02:02 UTC
[Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init()
Does it mean we can ignore the failure of creating debugfs? On 2014/10/21 23:02, Jan Kara wrote:> Remove assignment which is never used. > > Coverity-id: 1227009 > Signed-off-by: Jan Kara <jack at suse.cz> > --- > fs/ocfs2/super.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c > index 93c85bc745e1..e1be0f0ea411 100644 > --- a/fs/ocfs2/super.c > +++ b/fs/ocfs2/super.c > @@ -1621,10 +1621,8 @@ static int __init ocfs2_init(void) > } > > ocfs2_debugfs_root = debugfs_create_dir("ocfs2", NULL); > - if (!ocfs2_debugfs_root) { > - status = -EFAULT; > + if (!ocfs2_debugfs_root) > mlog(ML_ERROR, "Unable to create ocfs2 debugfs root.\n"); > - } > > ocfs2_set_locking_protocol(); > >