Hi Andrew, can you please pull the following patch from Tetsuo Handa. It fixes a regression in ocfs2/mainline and linux-next Thanks, --Srini
Srinivas Eeda
2014-Mar-28 21:44 UTC
[Ocfs2-devel] [PATCH 1/1] ocfs2: Fix panic on kfree(xattr->name)
From: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp> Commit 9548906b 'xattr: Constify ->name member of "struct xattr".' missed that ocfs2 is calling kfree(xattr->name). As a result, kernel panic occurs upon calling kfree(xattr->name) because xattr->name refers static constant names. This patch removes kfree(xattr->name) from ocfs2_mknod() and ocfs2_symlink(). Reported-by: Tariq Saeed <tariq.x.saeed at oracle.com> Signed-off-by: Tetsuo Handa <penguin-kernel at I-love.SAKURA.ne.jp> Reviewed-by: Srinivas Eeda <srinivas.eeda at oracle.com> --- fs/ocfs2/namei.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 3683643..feed025f 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -450,7 +450,6 @@ leave: brelse(new_fe_bh); brelse(parent_fe_bh); - kfree(si.name); kfree(si.value); ocfs2_free_dir_lookup_result(&lookup); @@ -1855,7 +1854,6 @@ bail: brelse(new_fe_bh); brelse(parent_fe_bh); - kfree(si.name); kfree(si.value); ocfs2_free_dir_lookup_result(&lookup); if (inode_ac) -- 1.7.9.5