Jeff Liu
2013-Aug-06 06:24 UTC
[Ocfs2-devel] [PATCH] ocfs2: fix a memory leak at __ocfs2_move_extents()
From: Jie Liu <jeff.liu at oracle.com> The ocfs2 path is not properly freed which leads to a memory leak at __ocfs2_move_extents(). This patch stops the leaks of the ocfs2_path structure. Cc: Younger Liu <younger.liu at huawei.com> Signed-off-by: Jie Liu <jeff.liu at oracle.com> --- fs/ocfs2/move_extents.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c index f1fc172..37231d1 100644 --- a/fs/ocfs2/move_extents.c +++ b/fs/ocfs2/move_extents.c @@ -152,6 +152,7 @@ static int __ocfs2_move_extent(handle_t *handle, } out: + ocfs2_free_path(path); return ret; } -- 1.7.9.5
Younger Liu
2013-Aug-06 08:39 UTC
[Ocfs2-devel] [PATCH] ocfs2: fix a memory leak at __ocfs2_move_extents()
On 2013/8/6 14:24, Jeff Liu wrote:> From: Jie Liu <jeff.liu at oracle.com> > > The ocfs2 path is not properly freed which leads to a > memory leak at __ocfs2_move_extents(). > > This patch stops the leaks of the ocfs2_path structure. > > Cc: Younger Liu <younger.liu at huawei.com> > Signed-off-by: Jie Liu <jeff.liu at oracle.com>This patch looks fine to me. Reviewed-by: Younger Liu <younger.liu at huawei.com>> --- > fs/ocfs2/move_extents.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c > index f1fc172..37231d1 100644 > --- a/fs/ocfs2/move_extents.c > +++ b/fs/ocfs2/move_extents.c > @@ -152,6 +152,7 @@ static int __ocfs2_move_extent(handle_t *handle, > } > > out: > + ocfs2_free_path(path); > return ret; > } > >