xiaowei.hu at oracle.com
2013-May-28 01:12 UTC
[Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory
From: "Xiaowei.Hu" <xiaowei.hu at oracle.com> Suppress the error message from being printed in ocfs2_rename Did same thing with Goldwyn Rodrigues last patch. While removing a non-empty directory, the kernel dumps a message: (mv,29521,1):ocfs2_rename:1474 ERROR: status = -39 Signed-off-by: Xiaowei Hu <xiaowei.hu at oracle.com> --- fs/ocfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 50c93a8..8ef1776 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -1470,7 +1470,7 @@ bail: brelse(old_dir_bh); brelse(new_dir_bh); - if (status) + if (status && (status != -ENOTEMPTY)) mlog_errno(status); return status; -- 1.7.11.7
Jeff Liu
2013-May-28 11:08 UTC
[Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory
On 05/28/2013 09:12 AM, xiaowei.hu at oracle.com wrote:> From: "Xiaowei.Hu" <xiaowei.hu at oracle.com> > > Suppress the error message from being printed in ocfs2_rename > Did same thing with Goldwyn Rodrigues last patch. > > While removing a non-empty directory, the kernel dumps a message: > (mv,29521,1):ocfs2_rename:1474 ERROR: status = -39 > > Signed-off-by: Xiaowei Hu <xiaowei.hu at oracle.com>Reviewed-by: Jie Liu <jeff.liu at oracle.com>> > --- > fs/ocfs2/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c > index 50c93a8..8ef1776 100644 > --- a/fs/ocfs2/namei.c > +++ b/fs/ocfs2/namei.c > @@ -1470,7 +1470,7 @@ bail: > brelse(old_dir_bh); > brelse(new_dir_bh); > > - if (status) > + if (status && (status != -ENOTEMPTY)) > mlog_errno(status); > > return status;