Hi! Today I encountered the following problem on v3.8: [ 28.940032] general protection fault: 0000 [#1] PREEMPT SMP ... [ 28.984953] Call Trace: [ 28.986628 [<ffffffffa04cb200>] ocfs2_fast_symlink_readpage+0x70/0x1b0 [ocfs2] [ 28.988302] [<ffffffff8110dc49>] ? add_to_page_cache_lru+0x29/0x40 [ 28.989942] [<ffffffff8110ddca>] do_read_cache_page+0x7a/0x170 [ 28.991573] [<ffffffff8110def4>] read_cache_page_async+0x14/0x20 [ 28.993212] [<ffffffff8110df09>] read_cache_page+0x9/0x20 [ 28.994827] [<ffffffff81170ae5>] page_getlink.isra.9+0x25/0x80 [ 28.996442] [<ffffffff81170b61>] page_follow_link_light+0x21/0x40 [ 28.998049] [<ffffffff8117090d>] generic_readlink+0x3d/0xa0 [ 28.999653] [<ffffffff8116c0db>] sys_readlinkat+0xfb/0x130 [ 29.001246] [<ffffffff8116c126>] sys_readlink+0x16/0x20 [ 29.002839] [<ffffffff815d8dad>] system_call_fastpath+0x1a/0x1f To my utter astonishment I found out that the issue is known since August 2012. And there is also a trivial fix for it.[0] The said fix found it''s way into Oracle Unbreakable Linux very quickly, but not into mainline.[1] Now I''m wondering how much Oracle really cares about OCFS2 in mainline? Maybe there are some more unfixed vulnerabilities? Not amused, //richard [0] http://www.mail-archive.com/ocfs2-devel@oss.oracle.com/msg07774.html [1] https://oss.oracle.com/pipermail/el-errata/2012-October/003103.html
On Mon, Feb 25, 2013 at 09:33:34PM +0100, Richard Weinberger wrote:> Today I encountered the following problem on v3.8: > [ 28.940032] general protection fault: 0000 [#1] PREEMPT SMP > ... > [ 28.984953] Call Trace: > [ 28.986628 [<ffffffffa04cb200>] ocfs2_fast_symlink_readpage+0x70/0x1b0 [ocfs2] > [ 28.988302] [<ffffffff8110dc49>] ? add_to_page_cache_lru+0x29/0x40 > [ 28.989942] [<ffffffff8110ddca>] do_read_cache_page+0x7a/0x170 > [ 28.991573] [<ffffffff8110def4>] read_cache_page_async+0x14/0x20 > [ 28.993212] [<ffffffff8110df09>] read_cache_page+0x9/0x20 > [ 28.994827] [<ffffffff81170ae5>] page_getlink.isra.9+0x25/0x80 > [ 28.996442] [<ffffffff81170b61>] page_follow_link_light+0x21/0x40 > [ 28.998049] [<ffffffff8117090d>] generic_readlink+0x3d/0xa0 > [ 28.999653] [<ffffffff8116c0db>] sys_readlinkat+0xfb/0x130 > [ 29.001246] [<ffffffff8116c126>] sys_readlink+0x16/0x20 > [ 29.002839] [<ffffffff815d8dad>] system_call_fastpath+0x1a/0x1fI've seen that patch actually and yes it should have been in mainline already. I didn't see whether it's in -mm (Andrew is pickup up some of the patches for us right now). I'll check and if it's not I'll try to send him a version of it today. --Mark -- Mark Fasheh
Smart Weblications GmbH - Florian Wiessner
2013-Feb-25 21:37 UTC
[Ocfs2-devel] OCFS2 mainline state?
Am 25.02.2013 21:33, schrieb Richard Weinberger:> Hi! > > Today I encountered the following problem on v3.8: > [ 28.940032] general protection fault: 0000 [#1] PREEMPT SMP > ... > [ 28.984953] Call Trace: > [ 28.986628 [<ffffffffa04cb200>] ocfs2_fast_symlink_readpage+0x70/0x1b0 [ocfs2] > [ 28.988302] [<ffffffff8110dc49>] ? add_to_page_cache_lru+0x29/0x40 > [ 28.989942] [<ffffffff8110ddca>] do_read_cache_page+0x7a/0x170 > [ 28.991573] [<ffffffff8110def4>] read_cache_page_async+0x14/0x20 > [ 28.993212] [<ffffffff8110df09>] read_cache_page+0x9/0x20 > [ 28.994827] [<ffffffff81170ae5>] page_getlink.isra.9+0x25/0x80 > [ 28.996442] [<ffffffff81170b61>] page_follow_link_light+0x21/0x40 > [ 28.998049] [<ffffffff8117090d>] generic_readlink+0x3d/0xa0 > [ 28.999653] [<ffffffff8116c0db>] sys_readlinkat+0xfb/0x130 > [ 29.001246] [<ffffffff8116c126>] sys_readlink+0x16/0x20 > [ 29.002839] [<ffffffff815d8dad>] system_call_fastpath+0x1a/0x1f > > To my utter astonishment I found out that the issue is known since August 2012. > And there is also a trivial fix for it.[0] > The said fix found it's way into Oracle Unbreakable Linux very quickly, > but not into mainline.[1] > > Now I'm wondering how much Oracle really cares about OCFS2 in mainline? > Maybe there are some more unfixed vulnerabilities? >I noticed and reported this on 07.02.2013 but got no reply ;( -- Mit freundlichen Gr??en, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Gesch?ftsf?hrer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz -------------- next part -------------- An embedded message was scrubbed... From: Smart Weblications GmbH - Florian Wiessner <f.wiessner at smart-weblications.de> Subject: problem with ocfs2 in 3.7.6 and 3.6.11 Date: Thu, 07 Feb 2013 03:04:27 +0100 Size: 10611 Url: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20130225/09e255b0/attachment-0001.mht
Hi
I was testing this path in august and i have two patch applied for ocfs2
The one your referring and also a changed in file.c
At the time of the test, the two patch were necessary ( and both
suppress a BUG although
not the same one)
Sorry i have no idea if it's still necessary or not, but i prefer to
send you a notice
Vincent ETIENNE
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -1998,7 +1998,7 @@ static long ocfs2_fallocate(struct file *file, int
mode, loff_t offset,
sr.l_start = (s64)offset;
sr.l_len = (s64)len;
- return __ocfs2_change_file_space(NULL, inode, offset, cmd, &sr,
+ return __ocfs2_change_file_space(file, inode, offset, cmd, &sr,
change_size);
}
diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c
index f1fbb4b..66edce7 100644
--- a/fs/ocfs2/symlink.c
+++ b/fs/ocfs2/symlink.c
@@ -57,7 +57,7 @@
static int ocfs2_fast_symlink_readpage(struct file *unused, struct page
*page)
{
struct inode *inode = page->mapping->host;
- struct buffer_head *bh;
+ struct buffer_head *bh = NULL;
int status = ocfs2_read_inode_block(inode, &bh);
struct ocfs2_dinode *fe;
const char *link;
Le 25/02/2013 21:33, Richard Weinberger a ?crit :> Hi!
>
> Today I encountered the following problem on v3.8:
> [ 28.940032] general protection fault: 0000 [#1] PREEMPT SMP
> ...
> [ 28.984953] Call Trace:
> [ 28.986628 [<ffffffffa04cb200>]
> ocfs2_fast_symlink_readpage+0x70/0x1b0 [ocfs2]
> [ 28.988302] [<ffffffff8110dc49>] ?
add_to_page_cache_lru+0x29/0x40
> [ 28.989942] [<ffffffff8110ddca>] do_read_cache_page+0x7a/0x170
> [ 28.991573] [<ffffffff8110def4>] read_cache_page_async+0x14/0x20
> [ 28.993212] [<ffffffff8110df09>] read_cache_page+0x9/0x20
> [ 28.994827] [<ffffffff81170ae5>] page_getlink.isra.9+0x25/0x80
> [ 28.996442] [<ffffffff81170b61>] page_follow_link_light+0x21/0x40
> [ 28.998049] [<ffffffff8117090d>] generic_readlink+0x3d/0xa0
> [ 28.999653] [<ffffffff8116c0db>] sys_readlinkat+0xfb/0x130
> [ 29.001246] [<ffffffff8116c126>] sys_readlink+0x16/0x20
> [ 29.002839] [<ffffffff815d8dad>] system_call_fastpath+0x1a/0x1f
>
> To my utter astonishment I found out that the issue is known since
> August 2012.
> And there is also a trivial fix for it.[0]
> The said fix found it's way into Oracle Unbreakable Linux very quickly,
> but not into mainline.[1]
>
> Now I'm wondering how much Oracle really cares about OCFS2 in mainline?
> Maybe there are some more unfixed vulnerabilities?
>
> Not amused,
> //richard
>
> [0] http://www.mail-archive.com/ocfs2-devel at oss.oracle.com/msg07774.html
> [1] https://oss.oracle.com/pipermail/el-errata/2012-October/003103.html
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>