Darrick J. Wong
2013-Jan-15 05:43 UTC
[Ocfs2-devel] [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages
When stable pages are required, we have to wait if the page is just going to disk and we want to modify it. Add proper callback to ocfs2_grab_pages_for_write(). CC: ocfs2-devel at oss.oracle.com CC: Joel Becker <jlbec at evilplan.org> CC: Mark Fasheh <mfasheh at suse.com> From: Jan Kara <jack at suse.cz> Signed-off-by: Jan Kara <jack at suse.cz> --- fs/ocfs2/aops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 6577432..9796330 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -1194,6 +1194,7 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping, goto out; } } + wait_for_stable_page(wc->w_pages[i]); if (index == target_index) wc->w_target_page = wc->w_pages[i];
Jan Kara
2013-Jan-15 10:15 UTC
[Ocfs2-devel] [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages
On Mon 14-01-13 21:43:13, Darrick J. Wong wrote:> When stable pages are required, we have to wait if the page is just > going to disk and we want to modify it. Add proper callback to > ocfs2_grab_pages_for_write(). > > CC: ocfs2-devel at oss.oracle.com > CC: Joel Becker <jlbec at evilplan.org> > CC: Mark Fasheh <mfasheh at suse.com> > From: Jan Kara <jack at suse.cz> > Signed-off-by: Jan Kara <jack at suse.cz>Darrick, to satisfy the kernel patch submission process you should also add your Signed-off-by to the patch... Honza> --- > fs/ocfs2/aops.c | 1 + > 1 file changed, 1 insertion(+) > > > diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c > index 6577432..9796330 100644 > --- a/fs/ocfs2/aops.c > +++ b/fs/ocfs2/aops.c > @@ -1194,6 +1194,7 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping, > goto out; > } > } > + wait_for_stable_page(wc->w_pages[i]); > > if (index == target_index) > wc->w_target_page = wc->w_pages[i]; >-- Jan Kara <jack at suse.cz> SUSE Labs, CR
Darrick J. Wong
2013-Jan-19 01:13 UTC
[Ocfs2-devel] [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages
When stable pages are required, we have to wait if the page is just going to disk and we want to modify it. Add proper callback to ocfs2_grab_pages_for_write(). CC: ocfs2-devel at oss.oracle.com CC: Joel Becker <jlbec at evilplan.org> CC: Mark Fasheh <mfasheh at suse.com> From: Jan Kara <jack at suse.cz> Signed-off-by: Jan Kara <jack at suse.cz> Signed-off-by: Darrick J. Wong <darrick.wong at oracle.com> --- fs/ocfs2/aops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 6577432..9796330 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -1194,6 +1194,7 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping, goto out; } } + wait_for_stable_page(wc->w_pages[i]); if (index == target_index) wc->w_target_page = wc->w_pages[i];