sunil.mushran at gmail.com
2012-Aug-03 16:36 UTC
[Ocfs2-devel] [PATCH] ocfs2: Fix oops in ocfs2_fast_symlink_readpage() code path
From: Sunil Mushran <smushran at yahoo.com>
Commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 was missing a var init.
Reported-and-Tested-by: Vincent Etienne <vetienne at aprogsys.com>
Signed-off-by: Sunil Mushran <sunil.mushran at gmail.com>
---
fs/ocfs2/symlink.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c
index f1fbb4b..66edce7 100644
--- a/fs/ocfs2/symlink.c
+++ b/fs/ocfs2/symlink.c
@@ -57,7 +57,7 @@
static int ocfs2_fast_symlink_readpage(struct file *unused, struct page *page)
{
struct inode *inode = page->mapping->host;
- struct buffer_head *bh;
+ struct buffer_head *bh = NULL;
int status = ocfs2_read_inode_block(inode, &bh);
struct ocfs2_dinode *fe;
const char *link;
--
1.7.4.4
Joel Becker
2012-Aug-15 06:40 UTC
[Ocfs2-devel] [PATCH] ocfs2: Fix oops in ocfs2_fast_symlink_readpage() code path
On Fri, Aug 03, 2012 at 05:36:17PM +0100, sunil.mushran at gmail.com wrote:> From: Sunil Mushran <smushran at yahoo.com> > > Commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 was missing a var init. > > Reported-and-Tested-by: Vincent Etienne <vetienne at aprogsys.com> > Signed-off-by: Sunil Mushran <sunil.mushran at gmail.com>This patch is now part of the fixes branch of ocfs2.git. Joel> --- > fs/ocfs2/symlink.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c > index f1fbb4b..66edce7 100644 > --- a/fs/ocfs2/symlink.c > +++ b/fs/ocfs2/symlink.c > @@ -57,7 +57,7 @@ > static int ocfs2_fast_symlink_readpage(struct file *unused, struct page *page) > { > struct inode *inode = page->mapping->host; > - struct buffer_head *bh; > + struct buffer_head *bh = NULL; > int status = ocfs2_read_inode_block(inode, &bh); > struct ocfs2_dinode *fe; > const char *link; > -- > 1.7.4.4 >-- "Born under a bad sign. I been down since I began to crawl. If it wasn't for bad luck, I wouldn't have no luck at all." http://www.jlbec.org/ jlbec at evilplan.org