Ocfs2 devel - Jul 2010 - [PATCH 27/36] fs/ocfs2: Remove unnecessary casts of private_data

Signed-off-by: Joe Perches <joe at perches.com>
---
 fs/ocfs2/dlm/dlmdebug.c |    6 +++---
 fs/ocfs2/dlmfs/dlmfs.c  |    3 +--
 fs/ocfs2/dlmglue.c      |    4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c
index 0cd24cf..5efdd37 100644
--- a/fs/ocfs2/dlm/dlmdebug.c
+++ b/fs/ocfs2/dlm/dlmdebug.c
@@ -419,7 +419,7 @@ static loff_t debug_buffer_llseek(struct file *file, loff_t
off, int whence)
 
 static int debug_buffer_release(struct inode *inode, struct file *file)
 {
-	struct debug_buffer *db = (struct debug_buffer *)file->private_data;
+	struct debug_buffer *db = file->private_data;
 
 	if (db)
 		kfree(db->buf);
@@ -715,7 +715,7 @@ static int debug_lockres_open(struct inode *inode, struct
file *file)
 		goto bail;
 	}
 
-	seq = (struct seq_file *) file->private_data;
+	seq = file->private_data;
 	seq->private = dl;
 
 	dlm_grab(dlm);
@@ -731,7 +731,7 @@ bail:
 
 static int debug_lockres_release(struct inode *inode, struct file *file)
 {
-	struct seq_file *seq = (struct seq_file *)file->private_data;
+	struct seq_file *seq = file->private_data;
 	struct debug_lockres *dl = (struct debug_lockres *)seq->private;
 
 	if (dl->dl_res)
diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c
index a43ebb1..c2903b8 100644
--- a/fs/ocfs2/dlmfs/dlmfs.c
+++ b/fs/ocfs2/dlmfs/dlmfs.c
@@ -182,8 +182,7 @@ static int dlmfs_file_release(struct inode *inode,
 {
 	int level, status;
 	struct dlmfs_inode_private *ip = DLMFS_I(inode);
-	struct dlmfs_filp_private *fp -		(struct dlmfs_filp_private *)
file->private_data;
+	struct dlmfs_filp_private *fp = file->private_data;
 
 	if (S_ISDIR(inode->i_mode))
 		BUG();
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 39eb16a..5e02a89 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -2966,7 +2966,7 @@ static const struct seq_operations ocfs2_dlm_seq_ops = {
 
 static int ocfs2_dlm_debug_release(struct inode *inode, struct file *file)
 {
-	struct seq_file *seq = (struct seq_file *) file->private_data;
+	struct seq_file *seq = file->private_data;
 	struct ocfs2_dlm_seq_priv *priv = seq->private;
 	struct ocfs2_lock_res *res = &priv->p_iter_res;
 
@@ -3000,7 +3000,7 @@ static int ocfs2_dlm_debug_open(struct inode *inode,
struct file *file)
 		goto out;
 	}
 
-	seq = (struct seq_file *) file->private_data;
+	seq = file->private_data;
 	seq->private = priv;
 
 	ocfs2_add_lockres_tracking(&priv->p_iter_res,
-- 
1.7.1.337.g6068.dirty

On Mon, Jul 12, 2010 at 01:50:19PM -0700, Joe Perches
wrote:
> Signed-off-by: Joe Perches <joe at perches.com>
> ---
>  fs/ocfs2/dlm/dlmdebug.c |    6 +++---
>  fs/ocfs2/dlmfs/dlmfs.c  |    3 +--
>  fs/ocfs2/dlmglue.c      |    4 ++--
>  3 files changed, 6 insertions(+), 7 deletions(-)
Acked-by: Joel Becker <joel.becker at oracle.com>

Btw, how hilarious is the comment for private_data?

Joel

-- 

A good programming language should have features that make the
kind of people who use the phrase "software engineering" shake
their heads disapprovingly.
	- Paul Graham

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

On Mon, 12 Jul 2010, Joel Becker wrote:
> On Mon, Jul 12, 2010 at 01:50:19PM -0700, Joe Perches wrote:
> > Signed-off-by: Joe Perches <joe at perches.com>
> > ---
> >  fs/ocfs2/dlm/dlmdebug.c |    6 +++---
> >  fs/ocfs2/dlmfs/dlmfs.c  |    3 +--
> >  fs/ocfs2/dlmglue.c      |    4 ++--
> >  3 files changed, 6 insertions(+), 7 deletions(-)
> 
> Acked-by: Joel Becker <joel.becker at oracle.com>
As this change is not present in linux-next as of today, I have applied 
it. Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.