Tao Ma
2010-Jun-01 05:58 UTC
[Ocfs2-devel] [PATCH] ocfs2: Add some trace log for orphan scan.
Now orphan scan worker has no trace log, so it is very hard to tell whether it is finished or blocked. So add 2 mlog trace log so that we can tell whether the current orphan scan worker is blocked or not. It does help when I analyzed a orphan scan bug. Signed-off-by: Tao Ma <tao.ma at oracle.com> --- fs/ocfs2/journal.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index 47878cf..776ab2f 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c @@ -1888,6 +1888,8 @@ void ocfs2_queue_orphan_scan(struct ocfs2_super *osb) os = &osb->osb_orphan_scan; + mlog(0, "Begin orphan scan\n"); + if (atomic_read(&os->os_state) == ORPHAN_SCAN_INACTIVE) goto out; @@ -1920,6 +1922,7 @@ void ocfs2_queue_orphan_scan(struct ocfs2_super *osb) unlock: ocfs2_orphan_scan_unlock(osb, seqno); out: + mlog(0, "Orphan scan completed\n"); return; } -- 1.5.5
Sunil Mushran
2010-Jun-01 17:23 UTC
[Ocfs2-devel] [PATCH] ocfs2: Add some trace log for orphan scan.
Signed-off-by: Sunil Mushran<sunil.mushran at oracle.com> On 05/31/2010 10:58 PM, Tao Ma wrote:> Now orphan scan worker has no trace log, so it is > very hard to tell whether it is finished or blocked. > So add 2 mlog trace log so that we can tell whether > the current orphan scan worker is blocked or not. > It does help when I analyzed a orphan scan bug. > > Signed-off-by: Tao Ma<tao.ma at oracle.com> > --- > fs/ocfs2/journal.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c > index 47878cf..776ab2f 100644 > --- a/fs/ocfs2/journal.c > +++ b/fs/ocfs2/journal.c > @@ -1888,6 +1888,8 @@ void ocfs2_queue_orphan_scan(struct ocfs2_super *osb) > > os =&osb->osb_orphan_scan; > > + mlog(0, "Begin orphan scan\n"); > + > if (atomic_read(&os->os_state) == ORPHAN_SCAN_INACTIVE) > goto out; > > @@ -1920,6 +1922,7 @@ void ocfs2_queue_orphan_scan(struct ocfs2_super *osb) > unlock: > ocfs2_orphan_scan_unlock(osb, seqno); > out: > + mlog(0, "Orphan scan completed\n"); > return; > } > >
Joel Becker
2010-Aug-12 00:31 UTC
[Ocfs2-devel] [PATCH] ocfs2: Add some trace log for orphan scan.
On Tue, Jun 01, 2010 at 01:58:13PM +0800, Tao Ma wrote:> Now orphan scan worker has no trace log, so it is > very hard to tell whether it is finished or blocked. > So add 2 mlog trace log so that we can tell whether > the current orphan scan worker is blocked or not. > It does help when I analyzed a orphan scan bug. > > Signed-off-by: Tao Ma <tao.ma at oracle.com>This patch is now in the merge-window branch of ocfs2.git. Joel -- "The nice thing about egotists is that they don't talk about other people." - Lucille S. Harper Joel Becker Consulting Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127