Wengang Wang
2010-Feb-26 10:18 UTC
[Ocfs2-devel] [PATCH] ocfs2: send SIGXFSZ if new filesize exceeds limit -v2
This patch makes ocfs2 send SIGXFSZ if new file size exceeds limit and abort the operation. No suprise that processes get SIGXFSZ on one node(in the cluster) while they don't on another if file size limits are different on the two nodes. Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com> --- fs/ocfs2/file.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 558ce03..a118cb0 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -993,10 +993,9 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr) } if (size_change && attr->ia_size != i_size_read(inode)) { - if (attr->ia_size > sb->s_maxbytes) { - status = -EFBIG; + status = inode_newsize_ok(inode, attr->ia_size); + if (status) goto bail_unlock; - } if (i_size_read(inode) > attr->ia_size) { if (ocfs2_should_order_data(inode)) { -- 1.6.6
Joel Becker
2010-Feb-28 04:11 UTC
[Ocfs2-devel] [PATCH] ocfs2: send SIGXFSZ if new filesize exceeds limit -v2
On Fri, Feb 26, 2010 at 06:18:25PM +0800, Wengang Wang wrote:> This patch makes ocfs2 send SIGXFSZ if new file size exceeds limit and abort the > operation. > No suprise that processes get SIGXFSZ on one node(in the cluster) while they > don't on another if file size limits are different on the two nodes. > > Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com>This patch is now in the 'merge-window' branch of ocfs2.git. Joel -- "A narcissist is someone better looking than you are." - Gore Vidal Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127