Tao Ma
2009-Jun-18 05:12 UTC
[Ocfs2-devel] [PATCH] ocfs2/trivial: Wrap ocfs2_sysfile_cluster_lock_key within define.
Actually ocfs2_sysfile_cluster_lock_key is only used if we enable CONFIG_DEBUG_LOCK_ALLOC. Wrap it so that we can avoid a building warning. fs/ocfs2/sysfile.c:53: warning: ?ocfs2_sysfile_cluster_lock_key? defined but not used Signed-off-by: Tao Ma <tao.ma at oracle.com> --- fs/ocfs2/sysfile.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/sysfile.c b/fs/ocfs2/sysfile.c index 6f53f5e..40e5370 100644 --- a/fs/ocfs2/sysfile.c +++ b/fs/ocfs2/sysfile.c @@ -50,7 +50,9 @@ static inline int is_in_system_inode_array(struct ocfs2_super *osb, int type, u32 slot); +#ifdef CONFIG_DEBUG_LOCK_ALLOC static struct lock_class_key ocfs2_sysfile_cluster_lock_key[NUM_SYSTEM_INODES]; +#endif static inline int is_global_system_inode(int type) { -- 1.6.2.rc2.16.gf474c
Joel Becker
2009-Jun-20 06:06 UTC
[Ocfs2-devel] [PATCH] ocfs2/trivial: Wrap ocfs2_sysfile_cluster_lock_key within define.
On Thu, Jun 18, 2009 at 01:12:06PM +0800, Tao Ma wrote:> Actually ocfs2_sysfile_cluster_lock_key is only used if we enable > CONFIG_DEBUG_LOCK_ALLOC. Wrap it so that we can avoid a building > warning. > fs/ocfs2/sysfile.c:53: warning: ?ocfs2_sysfile_cluster_lock_key? > defined but not used > > Signed-off-by: Tao Ma <tao.ma at oracle.com>This is now in the lockdep branch of ocfs2.git. Joel -- The Graham Corollary: The longer a socially-moderated news website exists, the probability of an old Paul Graham link appearing at the top approaches certainty. Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127
Maybe Matching Threads
- [PATCH 0/2] OCFS2 lockdep support
- [PATCH 0/7] OCFS2 locking fixes and lockdep annotations
- [PATCH 0/7] [RESEND] Fix some deadlocks in quota code and implement lockdep for cluster locks
- [GIT PULL] ocfs2 updates for 2.6.31, take 2
- [PATCH] ocfs2: Fix a bug found by sparse check.