Tao Ma
2009-Feb-16 20:39 UTC
[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.
In ctime updating of xattr, it use the wrong type of access for
inode, so use ocfs2_journal_access_di instead.
Signed-off-by: Tao Ma <tao.ma at oracle.com>
---
fs/ocfs2/xattr.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
index 915039f..e393315 100644
--- a/fs/ocfs2/xattr.c
+++ b/fs/ocfs2/xattr.c
@@ -2592,8 +2592,9 @@ static int __ocfs2_xattr_set_handle(struct inode *inode,
if (!ret) {
/* Update inode ctime. */
- ret = ocfs2_journal_access(ctxt->handle, inode, xis->inode_bh,
- OCFS2_JOURNAL_ACCESS_WRITE);
+ ret = ocfs2_journal_access_di(ctxt->handle, inode,
+ xis->inode_bh,
+ OCFS2_JOURNAL_ACCESS_WRITE);
if (ret) {
mlog_errno(ret);
goto out;
--
1.5.5
Joel Becker
2009-Feb-17 05:44 UTC
[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.
On Tue, Feb 17, 2009 at 04:39:28AM +0800, Tao Ma wrote:> In ctime updating of xattr, it use the wrong type of access for > inode, so use ocfs2_journal_access_di instead. > > Signed-off-by: Tao Ma <tao.ma at oracle.com>Eek! How did tristan's and my testing miss this? Mark, this is a bugfix for .29. Signed-off-by: Joel Becker <joel.becker at oracle.com> -- "In the beginning, the universe was created. This has made a lot of people very angry, and is generally considered to have been a bad move." - Douglas Adams Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127
Apparently Analagous Threads
- [PATCH V2] ocfs2: need rollback when journal_access failed in ocfs2_orphan_add()
- [PATCH] ocfs2: fix defrag path triggering jbd2 ASSERT
- [PATCH] fs: fs2fs: Replaced calls to kmalloc and memcpy with kmemdup
- [merged mm-hotfixes-stable] ocfs2-fix-defrag-path-triggering-jbd2-assert.patch removed from -mm tree
- Patch "ocfs2: fix defrag path triggering jbd2 ASSERT" has been added to the 4.19-stable tree