Andrew Beekhof
2008-Nov-18 10:18 UTC
[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts
Fix a number of LSB compliance issues reported by rpmlint regarding ocfs2 init scripts Signed-off-by: Andrew Beekhof <abeekhof at suse.de> --- upstream/vendor/common/o2cb.init.sh 2008-09-11 16:51:11.000000000 +0200 +++ dev/vendor/common/o2cb.init.sh 2008-10-23 14:36:49.000000000 +0200 @@ -8,7 +8,8 @@ # Provides: o2cb # Required-Start: $network # Should-Start: -# Required-Stop: +# Should-Stop: +# Required-Stop: $null # Default-Start: 2 3 5 # Default-Stop: # Short-Description: Load O2CB cluster services at system boot. --- upstream/vendor/common/ocfs2.init 2008-09-11 16:51:11.000000000 +0200 +++ dev/vendor/common/ocfs2.init 2008-10-23 13:13:55.000000000 +0200 @@ -8,9 +8,9 @@ ### BEGIN INIT INFO # Provides: ocfs2 # Required-Start: $network o2cb -# Required-Stop: -# X-UnitedLinux-Should-Start: -# X-UnitedLinux-Should-Stop: +# Required-Stop: $null +# Should-Start: +# Should-Stop: # Default-Start: 2 3 5 # Default-Stop: # Short-Description: Mount OCFS2 volumes at boot.
Joel Becker
2008-Nov-18 23:03 UTC
[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts
On Tue, Nov 18, 2008 at 11:18:38AM +0100, Andrew Beekhof wrote:> Fix a number of LSB compliance issues reported by rpmlint regarding > ocfs2 init scripts > > Signed-off-by: Andrew Beekhof <abeekhof at suse.de> > > --- upstream/vendor/common/o2cb.init.sh 2008-09-11 16:51:11.000000000 > +0200 > +++ dev/vendor/common/o2cb.init.sh 2008-10-23 14:36:49.000000000 +0200 > @@ -8,7 +8,8 @@ > # Provides: o2cb > # Required-Start: $network > # Should-Start: > -# Required-Stop: > +# Should-Stop: > +# Required-Stop: $nullReally, rpmlint requires everyone to know some magic $null? Who the heck thought that one up? Is it portable to all distros? Joel -- "There is no more evil thing on earth than race prejudice, none at all. I write deliberately -- it is the worst single thing in life now. It justifies and holds together more baseness, cruelty and abomination than any other sort of error in the world." - H. G. Wells Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127