Jan Kara
2008-Oct-24 22:10 UTC
[Ocfs2-devel] mkfs patch for creating filesystem with quota files
Hello, attached is a patch which implements necessary support for mkfs so that quota files can be created. Honza -- Jan Kara <jack at suse.cz> SUSE Labs, CR -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Implement-quota-support-to-mkfs-and-add-a-few-auxili.patch Type: text/x-patch Size: 16966 bytes Desc: not available Url : http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20081025/82529a5d/attachment.bin
Jan Kara
2008-Oct-25 09:32 UTC
[Ocfs2-devel] mkfs patch for creating filesystem with quota files
On Sat 25-10-08 00:10:22, Jan Kara wrote:> Hello, > > attached is a patch which implements necessary support for > mkfs so that quota files can be created.As Mark pointed to me, the patch missed the libocfs2/quota.c file. So a fixed patch is attached. Honza -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Implement-quota-support-to-mkfs-and-add-a-few-auxili.patch Type: text/x-patch Size: 25685 bytes Desc: not available Url : http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20081025/480790ed/attachment-0001.bin
tristan.ye
2008-Oct-27 06:55 UTC
[Ocfs2-devel] mkfs patch for creating filesystem with quota files
Jan, For tools patch,found something unhappy:( diff --git a/libocfs2/Makefile b/libocfs2/Makefile index 446c8b4..18cf2ee 100644 --- a/libocfs2/Makefile +++ b/libocfs2/Makefile @@ -72,6 +72,7 @@ CFILES = \ lockid.c \ backup_super.c \ feature_string.c\ + quota.c \ image.c Here,you did add a entry for quota.c in libocfs2's Makefile,while the file you wanna add can not be found through the whole patch. So after applying the patch on latest ocfs2-tools.git,we can not have it compiled successfully at all. I guess you may be forgetting to generate the patch for newly added quota.c file. Thanks and regards, Tristan. On Sat, 2008-10-25 at 00:10 +0200, Jan Kara wrote:> Hello, > > attached is a patch which implements necessary support for > mkfs so that quota files can be created. > Honza
tristan.ye
2008-Oct-27 07:39 UTC
[Ocfs2-devel] mkfs patch for creating filesystem with quota files
On Sat, 2008-10-25 at 11:32 +0200, Jan Kara wrote:> On Sat 25-10-08 00:10:22, Jan Kara wrote: > > Hello, > > > > attached is a patch which implements necessary support for > > mkfs so that quota files can be created. > As Mark pointed to me, the patch missed the libocfs2/quota.c > file. So a fixed patch is attached.Sorry for missing your second mail of mkfs patch, got the right one here,please just ignore my previous complaining about the quota.c :-) Regards, Tristan.> Honza