wen.gang.wang at oracle.com
2008-Jun-10 06:24 UTC
[Ocfs2-devel] [PATCH 1/1] ocfs2: Handle error during journal load
From: Wengang Wang <wen.gang.wang at oracle.com>
This patch ensures the mount fails if the fs is unable to load the journal.
Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com>
---
fs/ocfs2/super.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index df63ba2..ccecfe5 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -1703,7 +1703,11 @@ static int ocfs2_check_volume(struct ocfs2_super *osb)
local = ocfs2_mount_local(osb);
/* will play back anything left in the journal. */
- ocfs2_journal_load(osb->journal, local);
+ status = ocfs2_journal_load(osb->journal, local);
+ if (status < 0) {
+ mlog(ML_ERROR, "ocfs2 journal load failed! %d\n", status);
+ goto finally;
+ }
if (dirty) {
/* recover my local alloc if we didn't unmount cleanly. */
--
1.5.3.2
Sunil Mushran
2008-Jun-10 16:32 UTC
[Ocfs2-devel] [PATCH 1/1] ocfs2: Handle error during journal load
wen.gang.wang at oracle.com wrote:> From: Wengang Wang <wen.gang.wang at oracle.com> > > This patch ensures the mount fails if the fs is unable to load the journal. > > Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com> >Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
Mark Fasheh
2008-Jun-11 18:49 UTC
[Ocfs2-devel] [PATCH 1/1] ocfs2: Handle error during journal load
On Tue, Jun 10, 2008 at 02:24:48PM +0800, wen.gang.wang at oracle.com wrote:> From: Wengang Wang <wen.gang.wang at oracle.com> > > This patch ensures the mount fails if the fs is unable to load the journal.Ok, thanks for this. --Mark -- Mark Fasheh