Zhang, Sonic
2004-Mar-11 01:59 UTC
[Ocfs2-devel] FW: A patch to remove compile warnings and errors if enable memory debugging(OCFS_LINUX_MEM_DEBUG).
Hi, If I turn on memory debugging by "configure --enable-memdebug", the make process fails. So I revised several code lines in file ocfs.h and proc.c and generate this patch file. Could you please take a look at this patch and tell me if it is suitable to be applied to the source tree. Thank you. ********************************************* Sonic Zhang Software Engineer Intel China Software Lab Tel: (086)021-52574545-1667 iNet: 752-1667 ********************************************* -------------- next part -------------- A non-text attachment was scrubbed... Name: ocfs2-enable-memdebug.patch Type: application/octet-stream Size: 1308 bytes Desc: ocfs2-enable-memdebug.patch Url : http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20040311/d12d8d87/ocfs2-enable-memdebug.obj
Mark Fasheh
2004-Mar-11 20:10 UTC
[Ocfs2-devel] FW: A patch to remove compile warnings and errors if enable memory debugging(OCFS_LINUX_MEM_DEBUG).
On Thu, Mar 11, 2004 at 03:59:06PM +0800, Zhang, Sonic wrote:> > Hi, > > If I turn on memory debugging by "configure --enable-memdebug", > the make process fails. So I revised several code lines in file ocfs.h > and proc.c and generate this patch file. > > Could you please take a look at this patch and tell me if it is > suitable to be applied to the source tree.Looks good. It didn't apply cleanly, but it was a one-liner to fix so I did. In the future, can you please include patches inlined into your e-mail? It's much easier to look at that way. --Mark -- Mark Fasheh Software Developer, Oracle Corp mark.fasheh@oracle.com
Zhang, Sonic
2004-Mar-11 20:58 UTC
[Ocfs2-devel] FW: A patch to remove compile warnings and errors if enable memory debugging(OCFS_LINUX_MEM_DEBUG).
Hi Mark, OK, I will try to send the patch inline. But, I have to fix the auto-wrap problem in my outlook email client first. Who know how to disable auto-wrap in outlook? Thanks. ********************************************* Sonic Zhang Software Engineer Intel China Software Lab Tel: (086)021-52574545-1667 iNet: 752-1667 *********************************************=20 -----Original Message----- From: Mark Fasheh [mailto:mark.fasheh@oracle.com]=20 Sent: 2004=C4=EA3=D4=C212=C8=D5 10:10 To: Zhang, Sonic Cc: Ocfs2-Devel Subject: Re: [Ocfs2-devel] FW: A patch to remove compile warnings and errors if enable memory debugging(OCFS_LINUX_MEM_DEBUG). On Thu, Mar 11, 2004 at 03:59:06PM +0800, Zhang, Sonic wrote:>=20 > Hi, >=20 > If I turn on memory debugging by "configure --enable-memdebug", > the make process fails. So I revised several code lines in file ocfs.h > and proc.c and generate this patch file. >=20 > Could you please take a look at this patch and tell me if it is > suitable to be applied to the source tree.Looks good. It didn't apply cleanly, but it was a one-liner to fix so I did. In the future, can you please include patches inlined into your e-mail? It's much easier to look at that way. --Mark -- Mark Fasheh Software Developer, Oracle Corp mark.fasheh@oracle.com
Joel Becker
2004-Mar-12 01:40 UTC
[Ocfs2-devel] FW: A patch to remove compile warnings and errors if enable memory debugging(OCFS_LINUX_MEM_DEBUG).
On Fri, Mar 12, 2004 at 10:58:25AM +0800, Zhang, Sonic wrote:> OK, I will try to send the patch inline. But, I have to fix the auto-wrap problem in my outlook email client first. Who know how to disable auto-wrap in outlook?Uninstall Outlook? Joel -- "There is no sincerer love than the love of food." - George Bernard Shaw Joel Becker Senior Member of Technical Staff Oracle Corporation E-mail: joel.becker@oracle.com Phone: (650) 506-8127