Florian Forster
2009-Jan-24 11:53 UTC
[Nut-upsdev] Patch to always install libupsclient-config
Hi, when building with the WITH_DEV conditional, either `libupsclient.pc' *or* `libupsclient-config' is installed. This is annoying when linking with libupsclient, because you basically have to do the check twice, once using `pkg-config' and once using `libupsclient-config'. Please consider the attached patch, which changes the behavior of `lib/Makefile.am' to install `libupsclient-config' regardless of whether `libupsclient.pc' is installed or not. Please CC me on replies. Regards, -octo -- Florian octo Forster Hacker in training GnuPG: 0x91523C3D http://verplant.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: nut-2.2.2-libconfig.patch Type: text/x-diff Size: 390 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20090124/d3a58367/attachment.patch -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20090124/d3a58367/attachment.pgp
Charles Lepple
2009-Jan-25 16:00 UTC
[Nut-upsdev] Patch to always install libupsclient-config
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Jan 24, 2009, at 6:53 AM, Florian Forster wrote:> Hi, > > when building with the WITH_DEV conditional, either `libupsclient.pc' > *or* `libupsclient-config' is installed. This is annoying when linking > with libupsclient, because you basically have to do the check twice, > once using `pkg-config' and once using `libupsclient-config'.Hi Florian, practically speaking, you probably only need to check for the libupsclient.pc - there are not many people out there who would have the library built properly, but who would have libupsclient-config instead of libupsclient.pc. In particular, I think libupsclient was not built on older versions of the Debian package, so people would either need to rebuild NUT from source with the library enabled, or find a backport. I think we were in the process of deprecating libupsclient-config. Arnaud, is this still the case? If so, we should probably change configure.in so that it prints an error if things don't look right for generating libupsclient.pc.> Please consider the attached patch, which changes the behavior of > `lib/Makefile.am' to install `libupsclient-config' regardless of > whether > `libupsclient.pc' is installed or not. > > Please CC me on replies. > > Regards, > -octo > -- > Florian octo Forster > Hacker in training > GnuPG: 0x91523C3D > http://verplant.org/<nut-2.2.2- > libconfig.patch>_______________________________________________ > Nut-upsdev mailing list > Nut-upsdev at lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev- -- Charles Lepple clepple at gmail -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAkl8jJQACgkQtJgYX7d0AdPqCQCZAT/zS8EqoiDZOxMoUkxltX2A Fp8AnjTJJgb4QNxqaTZ6v5/iNwv77AOw =n+HU -----END PGP SIGNATURE-----