Nut upsdev - Nov 2006 - Re: [nut-commits] svn commit r585 - in trunk: . conf server

It looks like the old default was 15 seconds, and the new default is 5
seconds. Was that intentional? -- Peter

Arjen de Korte wrote:
> 
> Modified: trunk/server/upsd.c
>
=============================================================================>
--- trunk/server/upsd.c	(original)
> +++ trunk/server/upsd.c	Thu Nov 16 21:16:40 2006
> @@ -45,7 +45,7 @@
>  	upstype	*firstups = NULL;
>  
>  	/* default 15 seconds before data is marked stale */
> -	int	maxage = 15;
> +	int	maxage = 15, maxinit = 5;
>  
>  	/* preloaded to STATEPATH in main, can be overridden via upsd.conf */
>  	char	*statepath = NULL;
> 
> Modified: trunk/server/upsd.h
>
=============================================================================>
--- trunk/server/upsd.h	(original)
> +++ trunk/server/upsd.h	Thu Nov 16 21:16:40 2006
> @@ -43,7 +43,6 @@
>  #include "ctype.h"
>  #include "upstype.h"
>  
> -#define INITIAL_WAIT_MAX 15	/* max 15 seconds for DUMPDONEs to arrive */
>  #define NUT_NET_ANSWER_MAX SMALLBUF
>  
>  /* prototypes from upsd.c */
>

[quickly passing by, since I just had my 2nd baby this morning ;-) ... ]

2006/11/16, Peter Selinger
<selinger@mathstat.dal.ca>:
> It looks like the old default was 15 seconds, and the new default is 5
> seconds. Was that intentional? -- Peter
first note that I never took time to comment on your 5 to 15 sec
evolution. now I do ;-)

the original value was 5, before you changed it. I think the 5 value
should be kept.
the 15 value is mostly needed for verbose smart units, such as
newhidups supported devices, which have (too) long startup procedures.
The problem is that some init systems will block the boot process for ie 15 sec.
The best solution would be to address such drivers startup time, ie by
dropping the initial update, and keeping only upon initups/info to do
an initial ping. We would then allow a longer time for the initial
data dump. Comments?

Arnaud
-- 
Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://people.debian.org/~aquette/
OpenSource Developer - http://arnaud.quette.free.fr/