Nut upsdev - Jan 2006 - Bug #302338 (genericups: custom configurationthrough ups.conf, not working)

On Tue, 31 Jan 2006, Arjen de Korte wrote:
> > But I'd like to know what I'm testing. Could you please post a
bug tracker
> > URL? I'm having trouble finding #302338.
> 
> That may be because I closed the bug (maybe a little overenthousiastic).
See
> 
>
http://alioth.debian.org/tracker/index.php?func=detail&aid=302338&group_id=30602&atid=411542
> 
> for one of the bugreports.
OK, and that leads to:

http://lists.alioth.debian.org/pipermail/nut-upsdev/2005-October/000172.html

But note that there are two issues in that post, and only one appears to
be addressed in the patch. The patch adds support for certain CyberPower
UPSen, but that should not have been necessary - the full custom
specification in upsd.conf should have worked, shouldn't it?

Or was the patch to CVS different to the CyberPower support patch, and 
directly addressed the custom config?

Thanks

--
Charlie

A: Because we read from top to bottom, left to right.
Q: Why should i start my reply below the quoted text?

Charlie Brady schreef:
> OK, and that leads to:
> 
>
http://lists.alioth.debian.org/pipermail/nut-upsdev/2005-October/000172.html
> 
> But note that there are two issues in that post, and only one appears to
> be addressed in the patch. The patch adds support for certain CyberPower
> UPSen, but that should not have been necessary - the full custom
> specification in upsd.conf should have worked, shouldn't it?
The latter should have worked, but I believe it never did (ouch!) since
the logic for the parse_input_signals() was wrong. The custom
configuration worked only if you solely used the overrides for the
output signals.
> Or was the patch to CVS different to the CyberPower support patch, and 
> directly addressed the custom config?
The latter. Check out the logic before and after the modification. In
case a user would specify (in ups.conf)

	OL = CTS

'*line' would be set correctly to TIOCM_CTS, but '*val' would be
set to
TIOCM_CTS | TIOCM_CD | TIOCM_RNG, while it should have been TIOCM_CTS
only. This is due to the fact that the code determining if one of these
should be included, only looked for the absence of -CTS, -DCD and -RNG.
In the above mentioned example, neither of these is present and it would
add all of their corresponding status bits. Like parse_output_signals()
it should also confirm that CTS, DCD and RNG respectively are present.

Regards, Arjen

Charlie Brady schreef:
> Or was the patch to CVS different to the CyberPower support patch, and 
> directly addressed the custom config?
There is a feature request for an unrelated issue, where the requester
quite extensively documents what goes wrong (if all bugreports would be
like this, our job would be a lot easier):

https://alioth.debian.org/tracker/index.php?func=detail&aid=301954&group_id=30602&atid=411545

The problem with the custom configuration not working is under item B).

Regards, Arjen