Nouveau - Dec 2025 - [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded

On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot
wrote:
> ???? /// Loads the FWSEC firmware into `falcon` and execute it.
> -??? pub(crate) fn run(
> -??????? &self,
> -??????? dev: &Device<device::Bound>,
> -??????? falcon: &Falcon<Gsp>,
> -??????? bar: &Bar0,
> -??? ) -> Result<()> {
> +??? pub(crate) fn run(&self, dev: &Device, falcon:
&Falcon<Gsp>, bar: &Bar0) -> Result<()> {
I frequently see patches that, when they change the function signature,
rearrange the parameters
from one line to multiple lines.  Here, you are doing the opposite.  Not only
that, but it seems
unnecessary because you're actually just changing one parameter, so you
should only be replacing
one line.

It seems to me that some people have their editors configured to prefer one
line, and others
have their editor configured to prefer multiple lines, so whenever there's a
signature change,
we get diffs like this.

On 12/8/25 8:18 AM, Timur Tabi wrote:
> On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote:
...
> I frequently see patches that, when they change the function signature,
rearrange the parameters
> from one line to multiple lines.  Here, you are doing the opposite.  Not
only that, but it seems
> unnecessary because you're actually just changing one parameter, so you
should only be replacing
> one line.
> 
> It seems to me that some people have their editors configured to prefer one
line, and others
> have their editor configured to prefer multiple lines, so whenever
there's a signature change,
> we get diffs like this.
Nope, what's actually happening is that (nearly) everyone has
their editor set up to run rustfmt(1) upon file save. That's
the convention used in Rust for Linux. (Failing that, one is
expected to run rustfmt before posting.)

It is a little jumpy, as you can see above, but it does have
the nice property of avoiding formatting discussions, since
there is only one way for things to end up.

thanks,
-- 
John Hubbard