Nouveau - Nov 2025 - [PATCH 6/6] gpu: nova-core: use gpu::Architecture instead of long lists of GPUs

On 11/6/25 1:42 PM, Danilo Krummrich wrote:
> On 11/6/25 3:41 PM, Timur Tabi wrote:
>> On Wed, 2025-11-05 at 19:54 -0800, John Hubbard wrote:
>>> -use crate::gpu::{Architecture, Chipset};
>>> +use crate::gpu::{
>>> +??? Architecture,
>>> +??? Chipset, //
>>> +};
>>
>> I don't think this change should be part of this patch.
> 
> I think it would be good to send a patch converting nova-core (and
nova-drm) to
> kernel vertical import style at once and then rebase other patches on top
of that.
Yes...thinking out loud, our fiercest merge/rebase conflicts lately
are not due to "use" statements, but other, more difficult items.

I'm thinking we can either do it, before or after the big pending
set of patches that have been posted so far, probably.

thanks,
John Hubbard

On 11/6/25 11:18 PM, John Hubbard wrote:
> I'm thinking we can either do it, before or after the big pending
> set of patches that have been posted so far, probably.
I'd prefer doing it before, it ensures we have consistent style throughout
the
driver and gives the chance to cleanup unnecessary imports that are covered by
prelude.