John Hubbard
2025-Nov-05 02:50 UTC
[PATCH v2 08/12] nova-core: sequencer: Add register opcodes
On 11/2/25 3:59 PM, Joel Fernandes wrote:> These opcodes are used for register write, modify, poll and store (save) > sequencer operations. > > Signed-off-by: Joel Fernandes <joelagnelf at nvidia.com> > --- > drivers/gpu/nova-core/gsp/sequencer.rs | 138 +++++++++++++++++++++++-- > 1 file changed, 131 insertions(+), 7 deletions(-)...> @@ -83,12 +116,103 @@ pub(crate) trait GspSeqCmdRunner { > fn run(&self, sequencer: &GspSequencer<'_>) -> Result; > } > > -impl GspSeqCmdRunner for GspSeqCmd { > - fn run(&self, _seq: &GspSequencer<'_>) -> Result { > +impl GspSeqCmdRunner for fw::GSP_SEQ_BUF_PAYLOAD_REG_WRITE { > + fn run(&self, sequencer: &GspSequencer<'_>) -> Result { > + dev_dbg!( > + sequencer.dev, > + "RegWrite: addr=0x{:x}, val=0x{:x}\n",Hi Joel, The RegRead, RegWrite, RegPoll prints generate over 400 lines per GPU, into the logs. This is too much, especially now that it's been working for a while. I'm thinking let's delete these entirely. If we somehow get into debugging this aspect of the sequencer, we can temporarily add whatever printing we need, but I think it's one notch too far for the final product, now that you have it working. thanks, -- John Hubbard
Joel Fernandes
2025-Nov-05 03:45 UTC
[PATCH v2 08/12] nova-core: sequencer: Add register opcodes
> On Nov 4, 2025, at 9:50?PM, John Hubbard <jhubbard at nvidia.com> wrote: > > ?On 11/2/25 3:59 PM, Joel Fernandes wrote: >> These opcodes are used for register write, modify, poll and store (save) >> sequencer operations. >> >> Signed-off-by: Joel Fernandes <joelagnelf at nvidia.com> >> --- >> drivers/gpu/nova-core/gsp/sequencer.rs | 138 +++++++++++++++++++++++-- >> 1 file changed, 131 insertions(+), 7 deletions(-) > ... >> @@ -83,12 +116,103 @@ pub(crate) trait GspSeqCmdRunner { >> fn run(&self, sequencer: &GspSequencer<'_>) -> Result; >> } >> >> -impl GspSeqCmdRunner for GspSeqCmd { >> - fn run(&self, _seq: &GspSequencer<'_>) -> Result { >> +impl GspSeqCmdRunner for fw::GSP_SEQ_BUF_PAYLOAD_REG_WRITE { >> + fn run(&self, sequencer: &GspSequencer<'_>) -> Result { >> + dev_dbg!( >> + sequencer.dev, >> + "RegWrite: addr=0x{:x}, val=0x{:x}\n", > > Hi Joel, > > The RegRead, RegWrite, RegPoll prints generate over 400 lines > per GPU, into the logs. This is too much, especially now that > it's been working for a while. > > I'm thinking let's delete these entirely. If we somehow get > into debugging this aspect of the sequencer, we can temporarily > add whatever printing we need, but I think it's one notch too > far for the final product, now that you have it working.Sure John, I am Ok with removing the prints. I will do so for the next spin. Thanks.> > > thanks, > -- > John Hubbard >