Alexandre Courbot
2025-Oct-25 03:35 UTC
[PATCH 1/1] nova-core: regs: rename .alter() --> .update()
Hi John, On Sat Oct 25, 2025 at 10:08 AM JST, John Hubbard wrote:> This also changes .try_alter() to try_update(). > > After this commit, instead of "read, write and alter", the methods > available for registers are now "read, write and update". > > This reads a lot easier for people who are used to working with > registers.I plan to apply this quickly as this was already discussed and agreed on, and to avoid conflicts with future patches. If that's ok with you I will add that this also aligns with what regmap does when applying. Also planning to add a `Link:` tag to https://lore.kernel.org/2c5d90c8-e73a-4f04-9c1d-30adbd0fef07 at nvidia.com for context.
John Hubbard
2025-Oct-25 03:45 UTC
[PATCH 1/1] nova-core: regs: rename .alter() --> .update()
Sounds good! (Apologies for top posting.) Thanks, John Hubbard ________________________________ From: Alexandre Courbot <acourbot at nvidia.com> Sent: Friday, October 24, 2025 8:35:39 PM To: John Hubbard <jhubbard at nvidia.com>; Danilo Krummrich <dakr at kernel.org> Cc: Alexandre Courbot <acourbot at nvidia.com>; Joel Fernandes <joelagnelf at nvidia.com>; Timur Tabi <ttabi at nvidia.com>; Alistair Popple <apopple at nvidia.com>; Edwin Peer <epeer at nvidia.com>; Zhi Wang <zhiw at nvidia.com>; David Airlie <airlied at gmail.com>; Simona Vetter <simona at ffwll.ch>; Bjorn Helgaas <bhelgaas at google.com>; Miguel Ojeda <ojeda at kernel.org>; Alex Gaynor <alex.gaynor at gmail.com>; Boqun Feng <boqun.feng at gmail.com>; Gary Guo <gary at garyguo.net>; Bj?rn Roy Baron <bjorn3_gh at protonmail.com>; Benno Lossin <lossin at kernel.org>; Andreas Hindborg <a.hindborg at kernel.org>; Alice Ryhl <aliceryhl at google.com>; Trevor Gross <tmgross at umich.edu>; nouveau at lists.freedesktop.org <nouveau at lists.freedesktop.org>; rust-for-linux at vger.kernel.org <rust-for-linux at vger.kernel.org>; LKML <linux-kernel at vger.kernel.org> Subject: Re: [PATCH 1/1] nova-core: regs: rename .alter() --> .update() Hi John, On Sat Oct 25, 2025 at 10:08 AM JST, John Hubbard wrote:> This also changes .try_alter() to try_update(). > > After this commit, instead of "read, write and alter", the methods > available for registers are now "read, write and update". > > This reads a lot easier for people who are used to working with > registers.I plan to apply this quickly as this was already discussed and agreed on, and to avoid conflicts with future patches. If that's ok with you I will add that this also aligns with what regmap does when applying. Also planning to add a `Link:` tag to https://lore.kernel.org/2c5d90c8-e73a-4f04-9c1d-30adbd0fef07 at nvidia.com for context. -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20251025/02e08d25/attachment.htm>