Nouveau - Oct 2025 - [PATCH v2 05/10] gpu: nova-core: gsp: Add GSP command queue handling

On 2025-09-30 at 00:45 +1000, Alexandre Courbot <acourbot at nvidia.com>
wrote...
> On Mon Sep 29, 2025 at 11:38 PM JST, Miguel Ojeda wrote:
> > On Mon, Sep 29, 2025 at 4:34?PM Alexandre Courbot <acourbot at
nvidia.com> wrote:
> >>
> >> I think you will also need to explicitly enable the feature
somewhere -
> >> for the kernel crate it is in `rust/kernel/lib.rs`, but Nova being
a
> >> different crate I am not sure where we are supposed to do it...
> >
> > `rust_allowed_features` in `scripts/Makefile.build`.
> 
> Ah, that's where it was! Thanks a lot!
Thanks. Is it still expected that `#[allow(clippy::incompatible_msrv)]` is
required? Just adding it to `rust_allowed_features` doesn't make the warning
go
away without the allow, but maybe I'm just doing something wrong...

On Tue, Sep 30, 2025 at 1:42?PM Alistair Popple <apopple at nvidia.com>
wrote:
>
> Thanks. Is it still expected that `#[allow(clippy::incompatible_msrv)]` is
> required? Just adding it to `rust_allowed_features` doesn't make the
warning go
> away without the allow, but maybe I'm just doing something wrong...
The warning is independent of the allowed features, and yeah, it is
expected that the Clippy may trigger (at this moment when we dance
with these features), so you can just allow it locally.

If it is too cumbersome, I may disable it globally.

I hope that helps!

Cheers,
Miguel

On 2025-09-30 at 21:58 +1000, Miguel Ojeda <miguel.ojeda.sandonis at
gmail.com> wrote...
> On Tue, Sep 30, 2025 at 1:42?PM Alistair Popple <apopple at
nvidia.com> wrote:
> >
> > Thanks. Is it still expected that
`#[allow(clippy::incompatible_msrv)]` is
> > required? Just adding it to `rust_allowed_features` doesn't make
the warning go
> > away without the allow, but maybe I'm just doing something
wrong...
> 
> The warning is independent of the allowed features, and yeah, it is
> expected that the Clippy may trigger (at this moment when we dance
> with these features), so you can just allow it locally.
> 
> If it is too cumbersome, I may disable it globally.
> 
> I hope that helps!
Thanks! That does help, it's not too cumbersome as we only use it in a few
places. I was just wondering if it was expected or not. A nice future quality
of life improvement might be to automatically disable clippy warnings for
everything in `rust_allowed_features` but I think that's pretty low
priority.
> Cheers,
> Miguel