Thomas Zimmermann
2025-Sep-30 13:14 UTC
[PATCH] drm/nouveau: Do not include drm_fb_helper.h
The driver doesn't need anything from <drm/drm_fb_helper.h>. Remove the include directive. Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index e97e39abf3a2..1d4d1bb63326 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -40,7 +40,6 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_edid.h> #include <drm/drm_eld.h> -#include <drm/drm_fb_helper.h> #include <drm/drm_fixed.h> #include <drm/drm_probe_helper.h> #include <drm/drm_vblank.h> -- 2.51.0
Hi,> The driver doesn't need anything from <drm/drm_fb_helper.h>. Remove > the include directive.Reviewed-by: Petr Vorel <pvorel at suse.cz> Kind regards, Petr ...> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -40,7 +40,6 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_edid.h> > #include <drm/drm_eld.h> > -#include <drm/drm_fb_helper.h>
Hi,> The driver doesn't need anything from <drm/drm_fb_helper.h>. Remove > the include directive.> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 - > 1 file changed, 1 deletion(-)> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c > index e97e39abf3a2..1d4d1bb63326 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -40,7 +40,6 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_edid.h> > #include <drm/drm_eld.h> > -#include <drm/drm_fb_helper.h> > #include <drm/drm_fixed.h> > #include <drm/drm_probe_helper.h> > #include <drm/drm_vblank.h>it looks to me that at least these 3 aren't needed either: #include <drm/display/drm_dp_helper.h> #include <drm/drm_atomic.h> #include <drm/drm_fixed.h> But maybe I miss something obvious. Kind regards, Petr