Tamir Duberstein
2025-Sep-25 13:54 UTC
[PATCH v2 18/19] rust: io: replace `kernel::c_str!` with C-Strings
C-String literals were added in Rust 1.77. Replace instances of
`kernel::c_str!` with C-String literals where possible.
Signed-off-by: Tamir Duberstein <tamird at gmail.com>
---
rust/kernel/io/mem.rs | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/rust/kernel/io/mem.rs b/rust/kernel/io/mem.rs
index 6f99510bfc3a..2e42eb906061 100644
--- a/rust/kernel/io/mem.rs
+++ b/rust/kernel/io/mem.rs
@@ -4,7 +4,6 @@
use core::ops::Deref;
-use crate::c_str;
use crate::device::Bound;
use crate::device::Device;
use crate::devres::Devres;
@@ -44,7 +43,7 @@ pub(crate) unsafe fn new(device: &'a
Device<Bound>, resource: &'a Resource) -> S
/// illustration purposes.
///
/// ```no_run
- /// use kernel::{bindings, c_str, platform, of, device::Core};
+ /// use kernel::{bindings, platform, of, device::Core};
/// struct SampleDriver;
///
/// impl platform::Driver for SampleDriver {
@@ -102,7 +101,7 @@ pub fn iomap_exclusive_sized<const SIZE: usize>(
/// illustration purposes.
///
/// ```no_run
- /// use kernel::{bindings, c_str, platform, of, device::Core};
+ /// use kernel::{bindings, platform, of, device::Core};
/// struct SampleDriver;
///
/// impl platform::Driver for SampleDriver {
@@ -164,7 +163,7 @@ impl<const SIZE: usize> ExclusiveIoMem<SIZE> {
fn ioremap(resource: &Resource) -> Result<Self> {
let start = resource.start();
let size = resource.size();
- let name = resource.name().unwrap_or(c_str!(""));
+ let name = resource.name().unwrap_or_default();
let region = resource
.request_region(
--
2.51.0
Benno Lossin
2025-Sep-25 22:12 UTC
[PATCH v2 18/19] rust: io: replace `kernel::c_str!` with C-Strings
On Thu Sep 25, 2025 at 3:54 PM CEST, Tamir Duberstein wrote:> C-String literals were added in Rust 1.77. Replace instances of > `kernel::c_str!` with C-String literals where possible. > > Signed-off-by: Tamir Duberstein <tamird at gmail.com>Reviewed-by: Benno Lossin <lossin at kernel.org> --- Cheers, Benno> --- > rust/kernel/io/mem.rs | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-)
Danilo Krummrich
2025-Sep-25 22:25 UTC
[PATCH v2 18/19] rust: io: replace `kernel::c_str!` with C-Strings
On 9/25/25 3:54 PM, Tamir Duberstein wrote:> C-String literals were added in Rust 1.77. Replace instances of > `kernel::c_str!` with C-String literals where possible. > > Signed-off-by: Tamir Duberstein <tamird at gmail.com>Acked-by: Danilo Krummrich <dakr at kernel.org>
Alice Ryhl
2025-Oct-01 09:28 UTC
[PATCH v2 18/19] rust: io: replace `kernel::c_str!` with C-Strings
On Thu, Sep 25, 2025 at 3:56?PM Tamir Duberstein <tamird at gmail.com> wrote:> > C-String literals were added in Rust 1.77. Replace instances of > `kernel::c_str!` with C-String literals where possible. > > Signed-off-by: Tamir Duberstein <tamird at gmail.com>Reviewed-by: Alice Ryhl <aliceryhl at google.com>