John Hubbard
2025-Aug-26 20:58 UTC
[PATCH v6 2/5] rust: pci: provide access to PCI Vendor values
On 8/26/25 1:45 PM, Danilo Krummrich wrote:> On 8/26/25 10:38 PM, John Hubbard wrote: >> On 8/25/25 5:47 AM, Danilo Krummrich wrote: >>> On Mon Aug 25, 2025 at 2:33 PM CEST, Alexandre Courbot wrote: >> ... > Sorry, that's on me being not precise. When I said private I meant private to > the parent module. > > The diff looks good, thanks!Huge relief! :)> > Please also make sure to add #[inline] where appropriate and rebase onto > driver-core-next.I have no idea "where appropriate" is, here. These are not hot paths, and the existing pci.rs methods such as Device::vendor_id() are not inlined, and so my initial approach is to just not inline any of this... thanks, -- John Hubbard
Danilo Krummrich
2025-Aug-26 21:00 UTC
[PATCH v6 2/5] rust: pci: provide access to PCI Vendor values
On 8/26/25 10:58 PM, John Hubbard wrote:> I have no idea "where appropriate" is, here. These are not hot paths, and > the existing pci.rs methods such as Device::vendor_id() are not inlined, > and so my initial approach is to just not inline any of this...I think we can inline those functions that only consist out of a single constructor (i.e. Self {...}) or a single function call either way.