On Mon Aug 4, 2025 at 4:17 PM CEST, Miguel Ojeda wrote:> On Mon, Aug 4, 2025 at 1:45?PM Alexandre Courbot <acourbot at
nvidia.com> wrote:
>> + if !self.0.is_power_of_two() {
>> + // SAFETY: per the invariants, `self.0` is always a power
of two so this block will
>> + // never be reached.
>> + unsafe { core::hint::unreachable_unchecked() }
>> + }
>
> I guess this one is here to help optimize users after they inline the
> cal? Is there a particular case you noticed? i.e. it may be worth
> mentioning it.
I suggested this in the previous version [1]. For example, it optimizes
division to only be a left shift.
[1]: https://lore.kernel.org/all/DBL1ZGZCSJF3.29HNS9BSN89C6 at kernel.org
---
Cheers,
Benno