On Fri, Aug 01, 2025 at 09:49:26PM -0400, Ethan Carter Edwards
wrote:> if (1) always evaluates to true. Remove the unneeded check.
>
> Signed-off-by: Ethan Carter Edwards <ethan at ethancedwards.com>
> ---
> .../gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/fifo.c | 36
++++++++++------------
> 1 file changed, 16 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/fifo.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/fifo.c
> index
1ac5628c5140e66d306a1aadce10c810886afad3..104c72ec359a07a318ac99f5c217f0b07db2b784
100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/fifo.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/fifo.c
> @@ -188,32 +188,28 @@ r535_chan_ramfc_write(struct nvkm_chan *chan, u64
offset, u64 length, u32 devm,
> if (ret)
> return ret;
>
> - if (1) {
> - NVA06F_CTRL_GPFIFO_SCHEDULE_PARAMS *ctrl;
> + NVA06F_CTRL_GPFIFO_SCHEDULE_PARAMS *ctrl;
>
> - if (1) {
> - NVA06F_CTRL_BIND_PARAMS *ctrl;
> + NVA06F_CTRL_BIND_PARAMS *ctrl;
>
I really don't like this business of declaring variables randomly
throughout the code, unless it's required for __cleanup magic. Anyway,
here it breaks the build.
regards,
dan carpenter