On 7/31/25 5:46 PM, Philipp Stanner wrote:> On Wed, 2025-04-09 at 13:02 +0200, Danilo Krummrich wrote:
>> (+ Ben)
>>
>> On Wed, Apr 09, 2025 at 11:14:14AM +0200, Philipp Stanner wrote:
>>> commit ebb945a94bba ("drm/nouveau: port all engines to new
engine module
>>> format") introduced a TODO to nouveau_chan.h, stating that an
>>> unspecified rework would take place in the "near future".
>>>
>>> Almost 13 years have passed since this "near future", so
it can be
>>> safely assumed that the TODO is not needed anymore. Besides, its
content
>>> is useless anyways since it does not specify *what* should have
been
>>> done.
>>>
>>> Remove the TODO.
>>>
>>> Signed-off-by: Philipp Stanner <phasta at kernel.org>
>>> ---
>>> ?drivers/gpu/drm/nouveau/nouveau_chan.h | 1 -
>>> ?1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.h
b/drivers/gpu/drm/nouveau/nouveau_chan.h
>>> index 016f668c0bc1..3b73ec91c4ff 100644
>>> --- a/drivers/gpu/drm/nouveau/nouveau_chan.h
>>> +++ b/drivers/gpu/drm/nouveau/nouveau_chan.h
>>> @@ -33,7 +33,6 @@ struct nouveau_channel {
>>> ? u64 addr;
>>> ? } push;
>>>
>>> - /* TODO: this will be reworked in the near future */
>>> ? bool accel_done;
>>
>> After having a brief look, it seems that it may has actually been
reworked;
>> there is only a single use of accel_done, which is in FIRE_RING(),
where it is
>> set to true. But it doesn't seem to be read from anywhere.
>>
>> So, I think we should remove both, the TODO and the accel_done field.
>>
>> @Ben: Maybe you remember the history of this.
>
> Since we didn't get an answer ? how do we want to continue with that,
> Danilo?
Removing the unused accel_done and the corresponding TODO should be fine,
let's
do that.