Danilo Krummrich
2025-Jul-11 18:03 UTC
[PATCH] gpu: nova-core: fix bounds check In PmuLookupTableEntry::new, data is sliced from 2..6, but the bounds check data.len() < 5 does not satisfy those bounds.
Hi Rhys, On Fri Jul 11, 2025 at 11:30 AM CEST, Quaternions wrote:> Signed-off-by: Rhys Lloyd <krakow20 at gmail.com>Thanks for your contribution. When sending patches, please make sure to follow the kernel's patch submission guidelines [1]. In particular, please stick to short and meaningful commit subject, followed by a commit description, even if the patch is simple and obvious. Also make sure to run ./scripts/checkpatch.pl and ./scripts/get_maintainer.pl to get your patches checked and find the correct list of people to send them to. Finally, please also consider the Rust submit checklist [2]. Thanks, Danilo [1] https://docs.kernel.org/process/submitting-patches.html [2] https://rust-for-linux.com/contributing#submit-checklist-addendum
Rhys Lloyd
2025-Jul-12 01:30 UTC
[PATCH] gpu: nova-core: fix bounds check In PmuLookupTableEntry::new, data is sliced from 2..6, but the bounds check data.len() < 5 does not satisfy those bounds.
Hi Danilo, I didn't understand the maintainers list yesterday, so all the patches I sent are missing mailing lists and recipients. I sent a second copy as requested in https://gitlab.freedesktop.org/drm/nova/-/merge_requests/4#note_3003142, and my mailing list mistakes were pointed out in detail. I also sent a fixed up v2 to the rust-for-linux mailing list only. If I need to send out another copy let me know, thanks. On Fri, Jul 11, 2025 at 11:03?AM Danilo Krummrich <dakr at kernel.org> wrote:> > Hi Rhys, > > On Fri Jul 11, 2025 at 11:30 AM CEST, Quaternions wrote: > > Signed-off-by: Rhys Lloyd <krakow20 at gmail.com> > > Thanks for your contribution. > > When sending patches, please make sure to follow the kernel's patch submission > guidelines [1]. > > In particular, please stick to short and meaningful commit subject, followed by > a commit description, even if the patch is simple and obvious. > > Also make sure to run ./scripts/checkpatch.pl and ./scripts/get_maintainer.pl to > get your patches checked and find the correct list of people to send them to. > > Finally, please also consider the Rust submit checklist [2]. > > Thanks, > Danilo > > [1] https://docs.kernel.org/process/submitting-patches.html > [2] https://rust-for-linux.com/contributing#submit-checklist-addendum
Danilo Krummrich
2025-Jul-12 13:11 UTC
[PATCH] gpu: nova-core: fix bounds check In PmuLookupTableEntry::new, data is sliced from 2..6, but the bounds check data.len() < 5 does not satisfy those bounds.
On Sat Jul 12, 2025 at 3:30 AM CEST, Rhys Lloyd wrote:> Hi Danilo, > I didn't understand the maintainers list yesterday, so all the patches > I sent are missing mailing lists and recipients. I sent a second copy > as requested in > https://gitlab.freedesktop.org/drm/nova/-/merge_requests/4#note_3003142, > and my mailing list mistakes were pointed out in detail. I also sent > a fixed up v2 to the rust-for-linux mailing list only. If I need to > send out another copy let me know, thanks.Can you please send a v2 following the instructions I linked in my previous reply? For your patch, scripts/get_maintainer.pl should give you Danilo Krummrich <dakr at kernel.org> (maintainer:CORE DRIVER FOR NVIDIA GPUS [RUST]) Alexandre Courbot <acourbot at nvidia.com> (maintainer:CORE DRIVER FOR NVIDIA GPUS [RUST]) David Airlie <airlied at gmail.com> (maintainer:DRM DRIVERS) Simona Vetter <simona at ffwll.ch> (maintainer:DRM DRIVERS) nouveau at lists.freedesktop.org (open list:CORE DRIVER FOR NVIDIA GPUS [RUST]) dri-devel at lists.freedesktop.org (open list:DRM DRIVERS) linux-kernel at vger.kernel.org (open list) Additionally, it makes sense to also add rust-for-linux at vger.kernel.org. - Danilo