Danilo Krummrich
2025-Jul-07 14:26 UTC
[PATCH v2 7/7] drm/nouveau: Remove waitque for sched teardown
On 7/7/25 3:54 PM, Philipp Stanner wrote:> On Mon, 2025-07-07 at 15:47 +0200, Danilo Krummrich wrote: >> On 7/7/25 3:42 PM, Philipp Stanner wrote: >>> struct nouveau_sched contains a waitque needed to prevent >>> drm_sched_fini() from being called while there are still jobs >>> pending. >>> Doing so so far would have caused memory leaks. >>> >>> With the new memleak-free mode of operation switched on in >>> drm_sched_fini() by providing the callback >>> nouveau_sched_fence_context_kill() the waitque is not necessary >>> anymore. >>> >>> Remove the waitque. >>> >>> Signed-off-by: Philipp Stanner <phasta at kernel.org> >> >> Doesn't this break the driver until fixed up by the subsequent patch? >> > > Did you mean to answer to patch 6? > > Patch 6 implements the cancel_job() callback for nouveau, which makes > sure the (still existing) waitque will never block. The, now redundant, > waitque then gets removed in patch 7.Yup, I mixed up the order on my end. Acked-by: Danilo Krummrich <dakr at kernel.org>