Timur Tabi
2025-Jul-03 21:26 UTC
[PATCH] drm/nouveau: Do not fail module init on debugfs errors
On Thu, 2025-07-03 at 21:19 +0000, Aaron Thompson wrote:> From: Aaron Thompson <dev at aaront.org> > > If CONFIG_DEBUG_FS is enabled, nouveau_drm_init() returns an error if it > fails to create the "nouveau" directory in debugfs. One case where that > will happen is when debugfs access is restricted by > CONFIG_DEBUG_FS_ALLOW_NONE or by the boot parameter debugfs=off, which > cause the debugfs APIs to return -EPERM. > > So just ignore errors from debugfs. Note that nouveau_debugfs_root may > be an error now, but that is a standard pattern for debugfs. From > include/linux/debugfs.h: > > "NOTE: it's expected that most callers should _ignore_ the errors > returned by this function. Other debugfs functions handle the fact that > the "dentry" passed to them could be an error and they don't crash in > that case. Drivers should generally work fine even if debugfs fails to > init anyway." > > Fixes: 97118a1816d2 ("drm/nouveau: create module debugfs root")Oof, sorry about that. I should have noticed this behavior when I reviewed this patch. Acked-by: Timur Tabi <ttabi at nvidia.com>