Alice Ryhl
2025-Jul-01 10:44 UTC
[PATCH v12 0/5] rust: replace kernel::str::CStr w/ core::ffi::CStr
On Thu, Jun 19, 2025 at 11:06:24AM -0400, Tamir Duberstein wrote:> This picks up from Michal Rostecki's work[0]. Per Michal's guidance I > have omitted Co-authored tags, as the end result is quite different. > > Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorovsky at protonmail.com/t/#u [0] > Closes: https://github.com/Rust-for-Linux/linux/issues/1075 > > Signed-off-by: Tamir Duberstein <tamird at gmail.com>Overall LGTM. Only question is whether we should re-export core::ffi::CStr from kernel::ffi. Reason being that right now we are telling people to never use core::ffi as the integer types are wrong, and I think it would be nice if we can continue to tell people "never use core::ffi". Either way, for the whole series: Reviewed-by: Alice Ryhl <aliceryhl at google.com> Alice