On 12.06.25 11:32, Zhenghan Cheng wrote:> After commit a934a57a42f64a4 ("scripts/misc-check: > check missing #include <linux/export.h> when W=1") > and commit 7d95680d64ac8e836c ("scripts/misc-check: > check unnecessary #include <linux/export.h> when W=1"), > we get some build warnings with W=1,such as: > > arch/x86/coco/sev/core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > arch/x86/crypto/aria_aesni_avx2_glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > arch/x86/kernel/unwind_orc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > arch/x86/kvm/hyperv.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > arch/x86/events/intel/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > arch/x86/events/zhaoxin/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > arch/x86/kernel/crash.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > arch/x86/kernel/devicetree.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > > so fix these build warnings for x86. > > Signed-off-by: "Zhenghan Cheng" <chengzhenghan at uniontech.com> > Suggested-by: "Huacai Chen" <chenhuacai at loongson.cn>For Xen and paravirt: Acked-by: Juergen Gross <jgross at suse.com> Your patch is looking a little bit strange, as the list of modified files is located between the patch hunks, followed by another "Signed-off-by:". Juergen -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_0xB0DE9DD628BF132F.asc Type: application/pgp-keys Size: 3683 bytes Desc: OpenPGP public key URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20250612/9e97cb07/attachment.key> -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature.asc Type: application/pgp-signature Size: 495 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20250612/9e97cb07/attachment.sig>
On Thu, Jun 12, 2025 at 1:19?PM Juergen Gross <jgross at suse.com> wrote:> > On 12.06.25 11:32, Zhenghan Cheng wrote: > > After commit a934a57a42f64a4 ("scripts/misc-check: > > check missing #include <linux/export.h> when W=1") > > and commit 7d95680d64ac8e836c ("scripts/misc-check: > > check unnecessary #include <linux/export.h> when W=1"), > > we get some build warnings with W=1,such as: > > > > arch/x86/coco/sev/core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > arch/x86/crypto/aria_aesni_avx2_glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > arch/x86/kernel/unwind_orc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > arch/x86/kvm/hyperv.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > arch/x86/events/intel/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > > arch/x86/events/zhaoxin/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > > arch/x86/kernel/crash.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > > arch/x86/kernel/devicetree.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present > > > > so fix these build warnings for x86. > > > > Signed-off-by: "Zhenghan Cheng" <chengzhenghan at uniontech.com> > > Suggested-by: "Huacai Chen" <chenhuacai at loongson.cn> > > For Xen and paravirt: > > Acked-by: Juergen Gross <jgross at suse.com> > > Your patch is looking a little bit strange, as the list of modified files > is located between the patch hunks, followed by another "Signed-off-by:".Indeed. And at bare minimum please split at least to two: 1) adding export.h; 2) removing export.h. -- With Best Regards, Andy Shevchenko