Bagas Sanjaya
2025-Jun-11 02:08 UTC
[PATCH v2] Documentation: nouveau: Update GSP message queue kernel-doc reference
GSP message queue docs has been moved following RPC handling split in
8a8b1ec5261f20 ("drm/nouveau/gsp: split rpc handling out on its own"),
before GSP-RM implementation is versioned in c472d828348caf
("drm/nouveau/gsp: move subdev/engine impls to subdev/gsp/rm/r535/").
However, the kernel-doc reference in nouveau docs is left behind, which
triggers htmldocs warnings:
ERROR: Cannot find file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
WARNING: No kernel-doc for file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
Update the reference.
Fixes: c472d828348c ("drm/nouveau/gsp: move subdev/engine impls to
subdev/gsp/rm/r535/")
Fixes: 8a8b1ec5261f ("drm/nouveau/gsp: split rpc handling out on its
own")
Signed-off-by: Bagas Sanjaya <bagasdotme at gmail.com>
---
Changes since v1 [1]:
- Correct GSP kernel-doc reference file (Randy)
[1]: https://lore.kernel.org/linux-doc/20250610065258.41467-1-bagasdotme at
gmail.com/
Documentation/gpu/nouveau.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/gpu/nouveau.rst b/Documentation/gpu/nouveau.rst
index b8c801e0068cb0..cab2e81013bc5f 100644
--- a/Documentation/gpu/nouveau.rst
+++ b/Documentation/gpu/nouveau.rst
@@ -25,7 +25,7 @@ providing a consistent API to upper layers of the driver
stack.
GSP Support
------------------------
-.. kernel-doc:: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
+.. kernel-doc:: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/rpc.c
:doc: GSP message queue element
.. kernel-doc:: drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
--
An old man doll... just what I always wanted! - Clara
Randy Dunlap
2025-Jun-11 02:31 UTC
[PATCH v2] Documentation: nouveau: Update GSP message queue kernel-doc reference
On 6/10/25 7:08 PM, Bagas Sanjaya wrote:> GSP message queue docs has been moved following RPC handling split in > 8a8b1ec5261f20 ("drm/nouveau/gsp: split rpc handling out on its own"), > before GSP-RM implementation is versioned in c472d828348caf > ("drm/nouveau/gsp: move subdev/engine impls to subdev/gsp/rm/r535/"). > However, the kernel-doc reference in nouveau docs is left behind, which > triggers htmldocs warnings: > > ERROR: Cannot find file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > WARNING: No kernel-doc for file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > > Update the reference. > > Fixes: c472d828348c ("drm/nouveau/gsp: move subdev/engine impls to subdev/gsp/rm/r535/") > Fixes: 8a8b1ec5261f ("drm/nouveau/gsp: split rpc handling out on its own") > Signed-off-by: Bagas Sanjaya <bagasdotme at gmail.com>Acked-by: Randy Dunlap <rdunlap at infradead.org> Tested-by: Randy Dunlap <rdunlap at infradead.org> Thanks.> --- > Changes since v1 [1]: > > - Correct GSP kernel-doc reference file (Randy) > > [1]: https://lore.kernel.org/linux-doc/20250610065258.41467-1-bagasdotme at gmail.com/ > > Documentation/gpu/nouveau.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/gpu/nouveau.rst b/Documentation/gpu/nouveau.rst > index b8c801e0068cb0..cab2e81013bc5f 100644 > --- a/Documentation/gpu/nouveau.rst > +++ b/Documentation/gpu/nouveau.rst > @@ -25,7 +25,7 @@ providing a consistent API to upper layers of the driver stack. > GSP Support > ------------------------ > > -.. kernel-doc:: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > +.. kernel-doc:: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/rpc.c > :doc: GSP message queue element > > .. kernel-doc:: drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494-- ~Randy
Danilo Krummrich
2025-Jun-13 15:46 UTC
[PATCH v2] Documentation: nouveau: Update GSP message queue kernel-doc reference
On 6/11/25 4:08 AM, Bagas Sanjaya wrote:> GSP message queue docs has been moved following RPC handling split in > 8a8b1ec5261f20 ("drm/nouveau/gsp: split rpc handling out on its own"), > before GSP-RM implementation is versioned in c472d828348caf > ("drm/nouveau/gsp: move subdev/engine impls to subdev/gsp/rm/r535/"). > However, the kernel-doc reference in nouveau docs is left behind, which > triggers htmldocs warnings: > > ERROR: Cannot find file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > WARNING: No kernel-doc for file ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > > Update the reference. > > Fixes: c472d828348c ("drm/nouveau/gsp: move subdev/engine impls to subdev/gsp/rm/r535/") > Fixes: 8a8b1ec5261f ("drm/nouveau/gsp: split rpc handling out on its own") > Signed-off-by: Bagas Sanjaya <bagasdotme at gmail.com>Applied to drm-misc-fixes, thanks!