On Sat May 24, 2025 at 10:33 PM CEST, Tamir Duberstein wrote:> Clean up references to `kernel::str::CStr`. > > Signed-off-by: Tamir Duberstein <tamird at gmail.com> > --- > drivers/gpu/drm/drm_panic_qr.rs | 3 ++- > drivers/gpu/nova-core/firmware.rs | 2 +- > drivers/net/phy/ax88796b_rust.rs | 1 + > drivers/net/phy/qt2025.rs | 1 + > rust/kernel/device.rs | 3 +-- > rust/kernel/driver.rs | 4 ++-- > rust/kernel/error.rs | 6 ++---- > rust/kernel/faux.rs | 5 ++++- > rust/kernel/firmware.rs | 15 ++++----------- > rust/kernel/kunit.rs | 6 +++--- > rust/kernel/lib.rs | 2 +- > rust/kernel/miscdevice.rs | 3 +-- > rust/kernel/net/phy.rs | 4 +++- > rust/kernel/of.rs | 3 ++- > rust/kernel/pci.rs | 2 +- > rust/kernel/platform.rs | 2 +- > rust/kernel/prelude.rs | 5 +---- > rust/kernel/str.rs | 22 ++++++++++------------ > rust/kernel/sync/condvar.rs | 4 ++-- > rust/kernel/sync/lock.rs | 4 ++-- > rust/kernel/sync/lock/global.rs | 5 +++-- > rust/kernel/sync/poll.rs | 1 + > rust/kernel/workqueue.rs | 1 + > rust/macros/module.rs | 2 +- > 24 files changed, 51 insertions(+), 55 deletions(-)Haven't compile tested this series yet, but this commit seems to suggest to me that some of the previous commits introduced code that doesn't compile or emits warnings? If so that needs to be fixed. --- Cheers, Benno
Tamir Duberstein
2025-May-26 22:31 UTC
[PATCH v10 5/5] rust: remove core::ffi::CStr reexport
On Mon, May 26, 2025 at 11:05?AM Benno Lossin <lossin at kernel.org> wrote:> > On Sat May 24, 2025 at 10:33 PM CEST, Tamir Duberstein wrote: > > Clean up references to `kernel::str::CStr`. > > > > Signed-off-by: Tamir Duberstein <tamird at gmail.com> > > --- > > drivers/gpu/drm/drm_panic_qr.rs | 3 ++- > > drivers/gpu/nova-core/firmware.rs | 2 +- > > drivers/net/phy/ax88796b_rust.rs | 1 + > > drivers/net/phy/qt2025.rs | 1 + > > rust/kernel/device.rs | 3 +-- > > rust/kernel/driver.rs | 4 ++-- > > rust/kernel/error.rs | 6 ++---- > > rust/kernel/faux.rs | 5 ++++- > > rust/kernel/firmware.rs | 15 ++++----------- > > rust/kernel/kunit.rs | 6 +++--- > > rust/kernel/lib.rs | 2 +- > > rust/kernel/miscdevice.rs | 3 +-- > > rust/kernel/net/phy.rs | 4 +++- > > rust/kernel/of.rs | 3 ++- > > rust/kernel/pci.rs | 2 +- > > rust/kernel/platform.rs | 2 +- > > rust/kernel/prelude.rs | 5 +---- > > rust/kernel/str.rs | 22 ++++++++++------------ > > rust/kernel/sync/condvar.rs | 4 ++-- > > rust/kernel/sync/lock.rs | 4 ++-- > > rust/kernel/sync/lock/global.rs | 5 +++-- > > rust/kernel/sync/poll.rs | 1 + > > rust/kernel/workqueue.rs | 1 + > > rust/macros/module.rs | 2 +- > > 24 files changed, 51 insertions(+), 55 deletions(-) > > Haven't compile tested this series yet, but this commit seems to suggest > to me that some of the previous commits introduced code that doesn't > compile or emits warnings? If so that needs to be fixed.That's not the case. There are no warnings and no compilation failures in prior commits.
On Tue May 27, 2025 at 12:30 AM CEST, Tamir Duberstein wrote:> On Mon, May 26, 2025 at 11:05?AM Benno Lossin <lossin at kernel.org> wrote: >> >> On Sat May 24, 2025 at 10:33 PM CEST, Tamir Duberstein wrote: >> > Clean up references to `kernel::str::CStr`. >> > >> > Signed-off-by: Tamir Duberstein <tamird at gmail.com> >> > --- >> > drivers/gpu/drm/drm_panic_qr.rs | 3 ++- >> > drivers/gpu/nova-core/firmware.rs | 2 +- >> > drivers/net/phy/ax88796b_rust.rs | 1 + >> > drivers/net/phy/qt2025.rs | 1 + >> > rust/kernel/device.rs | 3 +-- >> > rust/kernel/driver.rs | 4 ++-- >> > rust/kernel/error.rs | 6 ++---- >> > rust/kernel/faux.rs | 5 ++++- >> > rust/kernel/firmware.rs | 15 ++++----------- >> > rust/kernel/kunit.rs | 6 +++--- >> > rust/kernel/lib.rs | 2 +- >> > rust/kernel/miscdevice.rs | 3 +-- >> > rust/kernel/net/phy.rs | 4 +++- >> > rust/kernel/of.rs | 3 ++- >> > rust/kernel/pci.rs | 2 +- >> > rust/kernel/platform.rs | 2 +- >> > rust/kernel/prelude.rs | 5 +---- >> > rust/kernel/str.rs | 22 ++++++++++------------ >> > rust/kernel/sync/condvar.rs | 4 ++-- >> > rust/kernel/sync/lock.rs | 4 ++-- >> > rust/kernel/sync/lock/global.rs | 5 +++-- >> > rust/kernel/sync/poll.rs | 1 + >> > rust/kernel/workqueue.rs | 1 + >> > rust/macros/module.rs | 2 +- >> > 24 files changed, 51 insertions(+), 55 deletions(-) >> >> Haven't compile tested this series yet, but this commit seems to suggest >> to me that some of the previous commits introduced code that doesn't >> compile or emits warnings? If so that needs to be fixed. > > That's not the case. There are no warnings and no compilation failures > in prior commits.Ah it's because of the `pub use`... I tested it both with 1.86 and 1.78 and aside from the `use<>` error reported by the bot everything worked. --- Cheers, Benno