Dan Carpenter
2025-Apr-30 08:06 UTC
[PATCH] drm/nouveau/fifo: small cleanup in nvkm_chan_cctx_get()
"&chan->cgrp->mutex" and "&cgrp->mutex" are the same thing. Use "&cgrp->mutex" consistently. It looks nicer and it silences a Smatch static checker warning. Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org> --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c index 7d4716dcd512..f5cd7f7c48b4 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c @@ -104,7 +104,7 @@ nvkm_chan_cctx_get(struct nvkm_chan *chan, struct nvkm_engn *engn, struct nvkm_c if (cctx) { refcount_inc(&cctx->refs); *pcctx = cctx; - mutex_unlock(&chan->cgrp->mutex); + mutex_unlock(&cgrp->mutex); return 0; } -- 2.47.2
Danilo Krummrich
2025-May-16 14:10 UTC
[PATCH] drm/nouveau/fifo: small cleanup in nvkm_chan_cctx_get()
On 4/30/25 10:06 AM, Dan Carpenter wrote:> "&chan->cgrp->mutex" and "&cgrp->mutex" are the same thing. Use > "&cgrp->mutex" consistently. It looks nicer and it silences a > Smatch static checker warning.Applied to drm-misc-next, thanks!