Danilo Krummrich
2025-Feb-04 18:46 UTC
[PATCH 1/2] gpu: nova-core: add initial driver stub
On Mon, Feb 03, 2025 at 03:24:10PM -0500, Joel Fernandes wrote:> Hi Danilo, > > On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote: > > +#[pin_data] > > +pub(crate) struct NovaCore { > > + #[pin] > > + pub(crate) gpu: Gpu, > > +} > > I am curious what is the need for pinning here in the patch in its current > form, is it for future-proofing?Yes, it is. It's not always needed, but since I know that further down the road we'll need at least a few mutexes, it seemed reasonable to already consider it.> > I looked through the sample PCI driver example you had posted and did not see > pinning there [1]. Thanks for the clarification. > [1] https://lore.kernel.org/all/20241219170425.12036-12-dakr at kernel.org/