Su Hui
2024-Apr-17 08:39 UTC
[PATCH] drm/nouveau/disp: fix an error problem in nvkm_uconn_new()
Clang Static Checker(scan-build) Warning:
drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c:line 215, column 4
Value stored to 'ret' is never read.
Return the error code rather than zero when 'conn->info.type' has an
unknown type.
Fixes: 8b7d92cad953 ("drm/nouveau/kms/nv50-: create connectors based on
nvkm info")
Signed-off-by: Su Hui <suhui at nfschina.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
index 2dab6612c4fc..6a67d307bf79 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
@@ -213,13 +213,14 @@ nvkm_uconn_new(const struct nvkm_oclass *oclass, void
*argv, u32 argc, struct nv
default:
WARN_ON(1);
ret = -EINVAL;
- break;
+ goto err;
}
nvkm_object_ctor(&nvkm_uconn, oclass, &conn->object);
*pobject = &conn->object;
ret = 0;
}
+err:
spin_unlock(&disp->client.lock);
return ret;
}
--
2.30.2