sunran001 at 208suo.com
2023-Jul-10 06:37 UTC
[Nouveau] [PATCH] drm/nouveau/i2c: do not use assignment in if condition
Assignments in if condition are less readable and error-prone. Fixes
also checkpatch warning:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001 at 208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c
index 96bbdda0f439..a1cf406ff141 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c
@@ -85,7 +85,8 @@ gf119_i2c_bus_new(struct nvkm_i2c_pad *pad, int id, u8
drive,
{
struct gf119_i2c_bus *bus;
- if (!(bus = kzalloc(sizeof(*bus), GFP_KERNEL)))
+ bus = kzalloc(sizeof(*bus), GFP_KERNEL);
+ if (!bus)
return -ENOMEM;
*pbus = &bus->base;
Karol Herbst
2023-Jul-13 09:08 UTC
[Nouveau] [PATCH] drm/nouveau/i2c: do not use assignment in if condition
Reviewed-by: Karol Herbst <kherbst at redhat.com> On Mon, Jul 10, 2023 at 9:23?AM <sunran001 at 208suo.com> wrote:> > Assignments in if condition are less readable and error-prone. Fixes > also checkpatch warning: > > ERROR: do not use assignment in if condition > > Signed-off-by: Ran Sun <sunran001 at 208suo.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c > index 96bbdda0f439..a1cf406ff141 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c > @@ -85,7 +85,8 @@ gf119_i2c_bus_new(struct nvkm_i2c_pad *pad, int id, u8 > drive, > { > struct gf119_i2c_bus *bus; > > - if (!(bus = kzalloc(sizeof(*bus), GFP_KERNEL))) > + bus = kzalloc(sizeof(*bus), GFP_KERNEL); > + if (!bus) > return -ENOMEM; > *pbus = &bus->base; >