Ben Dooks
2022-Dec-29 15:52 UTC
[Nouveau] [PATCH] drm/nouveau/mc/ga100: make ga100_mc_device static
Make ga100_mc_device static as it isn't exported, to fix the following sparse warning: drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol 'ga100_mc_device' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben-linux at fluff.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c index 1e2eabec1a76..5d28d30d09d5 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c @@ -47,7 +47,7 @@ ga100_mc_device_enabled(struct nvkm_mc *mc, u32 mask) return (nvkm_rd32(mc->subdev.device, 0x000600) & mask) == mask; } -const struct nvkm_mc_device_func +static const struct nvkm_mc_device_func ga100_mc_device = { .enabled = ga100_mc_device_enabled, .enable = ga100_mc_device_enable, -- 2.39.0
Karol Herbst
2023-Apr-11 14:05 UTC
[Nouveau] [PATCH] drm/nouveau/mc/ga100: make ga100_mc_device static
Reviewed-by: Karol Herbst <kherbst at redhat.com> On Thu, Dec 29, 2022 at 4:52?PM Ben Dooks <ben-linux at fluff.org> wrote:> > Make ga100_mc_device static as it isn't exported, to > fix the following sparse warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol 'ga100_mc_device' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben-linux at fluff.org> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c > index 1e2eabec1a76..5d28d30d09d5 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c > @@ -47,7 +47,7 @@ ga100_mc_device_enabled(struct nvkm_mc *mc, u32 mask) > return (nvkm_rd32(mc->subdev.device, 0x000600) & mask) == mask; > } > > -const struct nvkm_mc_device_func > +static const struct nvkm_mc_device_func > ga100_mc_device = { > .enabled = ga100_mc_device_enabled, > .enable = ga100_mc_device_enable, > -- > 2.39.0 >
Reasonably Related Threads
- [PATCH] drm/nouveau/mc/ga100: make ga100_mc_device static
- [PATCH] drm/nouveau/mc: set ga100_mc_device storage-class-specifier to static
- 5.9-rc7 oops in nvkm_udevice_info() w/ GA100
- [PATCH 1/3] drm/nouveau/kms/nv50-: make base917c_format static
- [PATCH 1/5] drm/nouveau/gr/gf100-: make undeclared symbols static