Hangyu Hua
2022-Sep-14 07:10 UTC
[Nouveau] [PATCH] drm: nouveau: move bounds checking to the front in nouveau_svm_fault_buffer_dtor()
It is better to check i before use it in array to avoid potential out of
bound access.
Signed-off-by: Hangyu Hua <hbh25y at gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/nouveau/nouveau_svm.c
index 31a5b81ee9fc..5c49a8eaf593 100644
--- a/drivers/gpu/drm/nouveau/nouveau_svm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
@@ -957,7 +957,7 @@ nouveau_svm_fault_buffer_dtor(struct nouveau_svm *svm, int
id)
int i;
if (buffer->fault) {
- for (i = 0; buffer->fault[i] && i < buffer->entries; i++)
+ for (i = 0; i < buffer->entries && buffer->fault[i]; i++)
kfree(buffer->fault[i]);
kvfree(buffer->fault);
}
--
2.34.1