Tom Rix
2022-May-28 14:18 UTC
[Nouveau] [PATCH] drm/nouveau/fifo/gv100-: set gv100_fifo_runlist storage-class to static
sparse reports
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c:56:1: warning: symbol
'gv100_fifo_runlist' was not declared. Should it be static?
gv100_fifo_runlist is only used in gv100.c, so change it to static.
Signed-off-by: Tom Rix <trix at redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c
b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c
index 70e16a91ac12..faf0fe9f704c 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c
@@ -52,7 +52,7 @@ gv100_fifo_runlist_cgrp(struct nvkm_fifo_cgrp *cgrp,
nvkm_wo32(memory, offset + 0xc, 0x00000000);
}
-const struct gk104_fifo_runlist_func
+static const struct gk104_fifo_runlist_func
gv100_fifo_runlist = {
.size = 16,
.cgrp = gv100_fifo_runlist_cgrp,
--
2.27.0
Lyude Paul
2022-May-31 18:51 UTC
[Nouveau] [PATCH] drm/nouveau/fifo/gv100-: set gv100_fifo_runlist storage-class to static
Reviewed-by: Lyude Paul <lyude at redhat.com> Will push to the appropriate branch in a moment On Sat, 2022-05-28 at 10:18 -0400, Tom Rix wrote:> sparse reports > drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c:56:1: warning: symbol > 'gv100_fifo_runlist' was not declared. Should it be static? > > gv100_fifo_runlist is only used in gv100.c, so change it to static. > > Signed-off-by: Tom Rix <trix at redhat.com> > --- > ?drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c | 2 +- > ?1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c > b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c > index 70e16a91ac12..faf0fe9f704c 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c > @@ -52,7 +52,7 @@ gv100_fifo_runlist_cgrp(struct nvkm_fifo_cgrp *cgrp, > ????????nvkm_wo32(memory, offset + 0xc, 0x00000000); > ?} > ? > -const struct gk104_fifo_runlist_func > +static const struct gk104_fifo_runlist_func > ?gv100_fifo_runlist = { > ????????.size = 16, > ????????.cgrp = gv100_fifo_runlist_cgrp,-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat