Jiapeng Chong
2022-May-05  08:13 UTC
[Nouveau] [PATCH] drm/nouveau/gr/gf100-: Clean up some inconsistent indenting
Eliminate the follow smatch warning:
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1925
gf100_gr_oneinit_tiles() warn: inconsistent indenting.
Reported-by: Abaci Robot <abaci at linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
---
 drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 397ff4fe9df8..f16eabf4f642 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1922,8 +1922,8 @@ gf100_gr_oneinit_tiles(struct gf100_gr *gr)
 
 	for (i = 0; i < gr->gpc_nr; i++) {
 		init_frac[i] = gr->tpc_nr[gpc_map[i]] * gr->gpc_nr * mul_factor;
-		 init_err[i] = i * gr->tpc_max * mul_factor - comm_denom/2;
-		  run_err[i] = init_frac[i] + init_err[i];
+		init_err[i] = i * gr->tpc_max * mul_factor - comm_denom/2;
+		run_err[i] = init_frac[i] + init_err[i];
 	}
 
 	for (i = 0; i < gr->tpc_total;) {
-- 
2.20.1.7.g153144c
Lyude Paul
2022-May-05  19:09 UTC
[Nouveau] [PATCH] drm/nouveau/gr/gf100-: Clean up some inconsistent indenting
Thanks! Reviewed-by: Lyude Paul <lyude at redhat.com> Will push upstream in a moment On Thu, 2022-05-05 at 16:13 +0800, Jiapeng Chong wrote:> Eliminate the follow smatch warning: > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1925 > gf100_gr_oneinit_tiles() warn: inconsistent indenting. > > Reported-by: Abaci Robot <abaci at linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong at linux.alibaba.com> > --- > ?drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 4 ++-- > ?1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c > b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c > index 397ff4fe9df8..f16eabf4f642 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c > @@ -1922,8 +1922,8 @@ gf100_gr_oneinit_tiles(struct gf100_gr *gr) > ? > ????????for (i = 0; i < gr->gpc_nr; i++) { > ????????????????init_frac[i] = gr->tpc_nr[gpc_map[i]] * gr->gpc_nr * > mul_factor; > -??????????????? init_err[i] = i * gr->tpc_max * mul_factor - comm_denom/2; > -???????????????? run_err[i] = init_frac[i] + init_err[i]; > +???????????????init_err[i] = i * gr->tpc_max * mul_factor - comm_denom/2; > +???????????????run_err[i] = init_frac[i] + init_err[i]; > ????????} > ? > ????????for (i = 0; i < gr->tpc_total;) {-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat