Nouveau - May 2022 - [PATCH] drm/nouveau: remove trace_dma_fence_emit

Hardware drivers which don't have much difference between emit and init
shouldn't use this trace point.

Signed-off-by: Christian K?nig <christian.koenig at amd.com>
Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: Karol Herbst <kherbst at redhat.com>
Cc: Lyude Paul <lyude at redhat.com>
Cc: nouveau at lists.freedesktop.org
---
 drivers/gpu/drm/nouveau/nouveau_fence.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c
b/drivers/gpu/drm/nouveau/nouveau_fence.c
index 7f01dcf81fab..abcac7db4347 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fence.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
@@ -224,7 +224,6 @@ nouveau_fence_emit(struct nouveau_fence *fence, struct
nouveau_channel *chan)
 			       &fctx->lock, fctx->context, ++fctx->sequence);
 	kref_get(&fctx->fence_ref);
 
-	trace_dma_fence_emit(&fence->base);
 	ret = fctx->emit(fence);
 	if (!ret) {
 		dma_fence_get(&fence->base);
-- 
2.25.1

Reviewed-by: Lyude Paul <lyude at redhat.com>

Will push to the appropriate branch in a moment

On Tue, 2022-05-03 at 10:59 +0200, Christian K?nig
wrote:
> Hardware drivers which don't have much difference between emit and init
> shouldn't use this trace point.
> 
> Signed-off-by: Christian K?nig <christian.koenig at amd.com>
> Cc: Ben Skeggs <bskeggs at redhat.com>
> Cc: Karol Herbst <kherbst at redhat.com>
> Cc: Lyude Paul <lyude at redhat.com>
> Cc: nouveau at lists.freedesktop.org
> ---
> ?drivers/gpu/drm/nouveau/nouveau_fence.c | 1 -
> ?1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c
> b/drivers/gpu/drm/nouveau/nouveau_fence.c
> index 7f01dcf81fab..abcac7db4347 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
> @@ -224,7 +224,6 @@ nouveau_fence_emit(struct nouveau_fence *fence, struct
> nouveau_channel *chan)
> ?????????????????????????????? &fctx->lock, fctx->context,
++fctx-
> >sequence);
> ????????kref_get(&fctx->fence_ref);
> ?
> -???????trace_dma_fence_emit(&fence->base);
> ????????ret = fctx->emit(fence);
> ????????if (!ret) {
> ????????????????dma_fence_get(&fence->base);
-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat