Tom Rix
2022-Apr-22 18:51 UTC
[Nouveau] [PATCH] drm/nouveau/kms/gv100: use static for gv100_disp_core_mthd_[base|sor]
Sparse reports these issues
coregv100.c:27:1: warning: symbol 'gv100_disp_core_mthd_base' was not
declared. Should it be static?
coregv100.c:43:1: warning: symbol 'gv100_disp_core_mthd_sor' was not
declared. Should it be static?
These variables are only used in coregv100.c. Single file use
variables should be static, so add static to their storage-class specifier.
Signed-off-by: Tom Rix <trix at redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
index 448a515057c7..1d333c484a49 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
@@ -23,7 +23,7 @@
#include <subdev/timer.h>
-const struct nv50_disp_mthd_list
+static const struct nv50_disp_mthd_list
gv100_disp_core_mthd_base = {
.mthd = 0x0000,
.addr = 0x000000,
@@ -39,7 +39,7 @@ gv100_disp_core_mthd_base = {
}
};
-const struct nv50_disp_mthd_list
+static const struct nv50_disp_mthd_list
gv100_disp_core_mthd_sor = {
.mthd = 0x0020,
.addr = 0x000020,
--
2.27.0
Lyude Paul
2022-Apr-26 17:26 UTC
[Nouveau] [PATCH] drm/nouveau/kms/gv100: use static for gv100_disp_core_mthd_[base|sor]
Reviewed-by: Lyude Paul <lyude at redhat.com> Will push to the appropriate branch in a bit On Fri, 2022-04-22 at 14:51 -0400, Tom Rix wrote:> Sparse reports these issues > coregv100.c:27:1: warning: symbol 'gv100_disp_core_mthd_base' was not > declared. Should it be static? > coregv100.c:43:1: warning: symbol 'gv100_disp_core_mthd_sor' was not > declared. Should it be static? > > These variables are only used in coregv100.c.? Single file use > variables should be static, so add static to their storage-class specifier. > > Signed-off-by: Tom Rix <trix at redhat.com> > --- > ?drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c | 4 ++-- > ?1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c > b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c > index 448a515057c7..1d333c484a49 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c > @@ -23,7 +23,7 @@ > ? > ?#include <subdev/timer.h> > ? > -const struct nv50_disp_mthd_list > +static const struct nv50_disp_mthd_list > ?gv100_disp_core_mthd_base = { > ????????.mthd = 0x0000, > ????????.addr = 0x000000, > @@ -39,7 +39,7 @@ gv100_disp_core_mthd_base = { > ????????} > ?}; > ? > -const struct nv50_disp_mthd_list > +static const struct nv50_disp_mthd_list > ?gv100_disp_core_mthd_sor = { > ????????.mthd = 0x0020, > ????????.addr = 0x000020,-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat